Re: [w3c/manifest] Add support for defining a theme color for both light & dark modes (prefers color scheme) (#975)

I can't see any perf differences, but I'd be inclined to go with:

```
"color_overrides": [
  {
    "media": "(prefers-color-scheme: dark)",
    "theme_color": "#fff",
    "background_color": "#000"
  },
  {
    "media": "(prefers-color-scheme: light)",
    "theme_color": "#000",
    "background_color": "#fff"
  }
]
```

Just from an object creation POV. I'm personally not a huge fan of property names having a dual role. 

However, we will need to work out what to do when multiple media queries/features match. Last wins? first wins? Most specific wins? 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/issues/975#issuecomment-851958324

Received on Tuesday, 1 June 2021 09:01:47 UTC