Re: [w3c/manifest] Add support for defining a theme color for both light & dark modes (prefers color scheme) (#975)

Thanks @aarongustafson .

Looking at your example here, it looks a lot simpler than the CSS MQ which I am a fan of.

However, I still think this should be a list, not a dictionary. See my above comments about whether dictionary order should matter. If order matters, it would be clearer for `color_overrides` be a list instead:

```json
"color_overrides": [
  {
    "color-scheme": "dark",
    "theme_color": "#fff",
    "background_color": "#000"
  },
  {
    "color-scheme": "light",
    "theme_color": "#000",
    "background_color": "#fff"
  },
  {
    "color-scheme": "contrast-more",
    "theme_color": "#000",
    "background_color": "#fff"
  }
]
```

That way it's clear that this is an ordered fallback chain, just like other newly proposed features [`display_override`](https://wicg.github.io/manifest-incubations/index.html#display_override-member) and [`capture_links`](https://github.com/WICG/sw-launch/blob/main/declarative_link_capturing.md#proposal).

> Other key options like `media_overrides` or `preference_overrides` might make more sense than `color_overrides` if we want to allow folks to redefine icons and such too.

Perhaps `media_overrides` is the best of these three. I think "color" is too specific and "preference" is too broad for the sorts of things we're trying to capture here.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/issues/975#issuecomment-857438847