- From: Matt Giuca <notifications@github.com>
- Date: Fri, 11 Jun 2021 00:40:43 -0700
- To: w3c/manifest <manifest@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Friday, 11 June 2021 07:41:29 UTC
We're into bikeshed town! Let's go. > makes it clear that this is for changing existing values via "overrides" (and also draws the connection to `display_overrides`). The "overrides" has slightly different meaning in those two contexts: - `display_override` is essentially us cleaning up our past mistakes. It lets you put new values in front of `display`, values which aren't allowed in `display` for backwards-compatibility reasons. `"display_override": ["tabbed"]` says "I _always_ want `display` to be `"tabbed"`, if that's supported; otherwise fall back to `display`." - `media_override` (if that's what we call it) lets you override the top-level stated value for members like `theme_color`, with values that would _also_ be valid in the top level, but under user-chosen conditions. `"media_override": {"prefers_color_scheme": "light", "theme_color": "white"}` says "I want `theme_color` to be `"white"` under certain conditions." I think the word "override" makes sense to both of these, but they aren't analogous to each other, so I would try to avoid overloading that term. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/manifest/issues/975#issuecomment-859355365
Received on Friday, 11 June 2021 07:41:29 UTC