- From: Jen Simmons <notifications@github.com>
- Date: Tue, 01 Jun 2021 16:04:43 -0700
- To: w3c/manifest <manifest@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 1 June 2021 23:05:21 UTC
Yeah, hot take — I’m not sure what `media_override` means. Overriding? What am I overriding? Isn't all my code technically an override of previously-parsed code?
Instead, `media` matches what I’d write in HTML and in CSS. The more we can make the code similar in all three places, the better.
```
<meta name="theme-color" media="(prefers-color-scheme: light)" content="red">
<meta name="theme-color" media="(prefers-color-scheme: dark)" content="darkred">
```
```
@media (prefers-color-scheme: dark) {
img {
filter: brightness(.8) contrast(1.2);
}
}
```
```
"media": {
"(prefers-color-scheme: dark)": {
"theme_color": "#fff",
"background_color": "#000"
},
"(prefers-color-scheme: light)": {
"theme_color": "#000",
"background_color": "#fff"
}
}
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/issues/975#issuecomment-852544277
Received on Tuesday, 1 June 2021 23:05:21 UTC