Re: [w3c/manifest] Add support for defining a theme color for both light & dark modes (prefers color scheme) (#975)

@mgiuca wrote: 
> Some folks on my team pointed out that we already depend on CSS parsing for processing the manifest: for color values.

Yes. Gecko also handles this by normalizing color values to RGBA and then to a format Android supports: 

https://github.com/mozilla/gecko-dev/blob/fd2fe22dc1226cc475ace26d4dd84f155049763e/dom/manifest/ValueExtractor.jsm#L74-L83


This is easy to do for colors, because the conversion is done once, but it's specifically targeting Android. And I don't know what other formats, say, would be needed for Windows or MacOS should Firefox one day support those. 

> However, I still think this should be a list, not a dictionary. 

I  agree, as that would give us parity with how we use `ImageResource`s. 

The only thing I would change is the name `"color_overrides"`... I'd still just go with `"media"` for the reasons @jensimmons gave, and to not lock us into only affecting "color" stuff, should we need something else in the future.  

I think we are are getting close to agreement 🎉🙏🤞


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/issues/975#issuecomment-858326836