Re: [w3c/manifest] Add support for defining a theme color for both light & dark modes (prefers color scheme) (#975)

> Cool, I'm happy with Marcos proposal. Thanks for taking all this feedback on board!

Agreed. The consistent use of underscores makes it a lot easier to read too.

> Should we call it `media_preferences` instead of `user_preferences` if it's going to be restricted to preferences relating to colours and such? `user_preferences` seems quite generic, like for example it could incorporate languages and anything else the user wants to change.

I'm still not fully sold on `user_preferences` as the key. I keep drifting back to `media_overrides` as being more explicit because it establishes a more obvious connection to media queries via the "media" portion and makes it clear that this is for changing existing values via "overrides" (and also draws the connection to `display_overrides`).

Is it a hill I'm willing to die on? No. Would I prefer an obvious key name? Yes.

> (On the other hand, maybe we _could_ put language selection in here too... but that's probably overcomplicating the design.)

Please no 😅

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/issues/975#issuecomment-859326166