- From: Domenic Denicola <notifications@github.com>
- Date: Thu, 11 Jun 2015 13:16:57 -0700
- To: whatwg/streams <streams@noreply.github.com>
- Message-ID: <whatwg/streams/pull/361@github.com>
Doing a PR of @tyoshino's changes so I can do line comments. You can view, comment on, or merge this pull request online at: https://github.com/whatwg/streams/pull/361 -- Commit Summary -- * Add ReadableByteStreamByobReader * One more BYOB change * More BYOB change * Replaced RangeError with TypeError, fixed call to RequestReadableByteStreamPull * More work * Reference impl of ReadableByteStream * Some renaming, reordered PullFromReadableByteStream.* functions * Don't use IterResultObject for rejection. Replace one if with assert * Remove unnecessary substitution * Add state check. Fix return position. * Typo fix. Removed unnecessary try-catch * Remove unnecessary alias * Update reference impl. Spec is not synced yet * Half done * Fixed bugs * Reorg * More tests * More * More fix, redesign... * Tweak * More fix * Refactor * Tidy * WIP Broken * Working * More * More * Refine * Guard WIP * WIP. Updating frequency of pullInto * Almost fixed * Almost again * Working! * Renaming * Reorder function definitions * Working. Refactored * Remove some variables * Replace return undefined with return * Remove incorrect CallPullInto * More * Renaming * Working * More -- File Changes -- M index.bs (566) A reference-implementation/lib/readable-byte-stream.js (948) M reference-implementation/run-tests.js (4) A reference-implementation/test/readable-byte-stream.js (1415) -- Patch Links -- https://github.com/whatwg/streams/pull/361.patch https://github.com/whatwg/streams/pull/361.diff --- Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/pull/361
Received on Thursday, 11 June 2015 20:17:37 UTC