- From: Takeshi Yoshino <notifications@github.com>
- Date: Tue, 30 Jun 2015 03:47:57 -0700
- To: whatwg/streams <streams@noreply.github.com>
Received on Tuesday, 30 June 2015 10:48:27 UTC
> + this._closeRequested = true;
> +
> + return;
> + }
> +
> + const reader = stream._reader;
> +
> + if (reader === undefined || IsReadableByteStreamReader(reader)) {
> + CloseReadableByteStream(stream);
> + return;
> + }
> +
> + assert(IsReadableByteStreamByobReader(reader), 'reader must be ReadableByteStreamByobReader');
> +
> + if (this._pendingPullIntos.length > 0 && this._pendingPullIntos[0].bytesFilled > 0) {
> + DestroyReadableByteStreamController(this);
Actually two. Maybe you searched for Destroy. There's one with typo (Destory). Fixed by 186a2626e0b9f5825ccc10a769dc0e4f558c3f11.
We could have a helper to run both, but maybe leads to increase of texts and a little longer time to trace call path in reviewing?
---
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/361/files#r33560593
Received on Tuesday, 30 June 2015 10:48:27 UTC