Re: [streams] Byte stream update, including reference implementation (#361)

> +    }
> +
> +    if (IsReadableByteStreamReader(reader)) {
> +      if (reader._readRequests.length === 0) {
> +        EnqueueInReadableByteStreamController(this, chunk);
> +        return;
> +      }
> +
> +      assert(this._queue.length === 0);
> +
> +      const req = reader._readRequests.shift();
> +      // TODO: Detach chunk.
> +      req.resolve(CreateIterResultObject(chunk, false));
> +
> +      if (this._closeRequested === true) {
> +        CloseReadableByteStream(stream);

This is really confusing for me because of the _closeRequested issue. It seems now like there are two different _closeRequested members---one for the stream, and one for the controller? They should probably be renamed...

---
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/361/files#r33551053