Re: [streams] Byte stream update, including reference implementation (#361)

> +  }).catch(e => {
> +    t.fail(e);
> +    t.end();
> +  });
> +});
> +
> +test('ReadableByteStream: read(), then respond()', t => {
> +  let controller;
> +
> +  const rbs = new ReadableByteStream({
> +    start(c) {
> +      controller = c;
> +    },
> +    pull() {
> +      try {
> +        controller.respond(1);

> This is throwing because it's respond()ing but not to a pullInto(), right? I think the test title should say that, and also you should respond with a Uint8Array or something, because otherwise I'd expect a TypeError anyway when respond()ing with a number.

Sorry. I'll update the test titles to describe what's being tested more clearly.

`pull()` must not responded by `respond()` as there's no existing `pullInto()` i.e. no pending buffer to fill.

https://github.com/whatwg/streams/commit/ffaea95c7ea3acb55fdc371895a7c9476049fc85

---
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/361/files#r32507785

Received on Tuesday, 16 June 2015 10:19:45 UTC