Re: [streams] Byte stream update, including reference implementation (#361)

> +      this._closeRequested = true;
> +
> +      return;
> +    }
> +
> +    const reader = stream._reader;
> +
> +    if (reader === undefined || IsReadableByteStreamReader(reader)) {
> +      CloseReadableByteStream(stream);
> +      return;
> +    }
> +
> +    assert(IsReadableByteStreamByobReader(reader), 'reader must be ReadableByteStreamByobReader');
> +
> +    if (this._pendingPullIntos.length > 0 && this._pendingPullIntos[0].bytesFilled > 0) {
> +      DestroyReadableByteStreamController(this);

In all but one case, DestroyReadableByteStreamController is followed by ErrorReadableByteStream. It might be worth thinking about how to combine them into one function. If not possible, then that's fine.

---
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/361/files#r33549454