Re: [streams] Byte stream update, including reference implementation (#361)

> +
> +  reader._closedPromise_resolve(undefined);
> +  reader._closedPromise_resolve = undefined;
> +  reader._closedPromise_reject = undefined;
> +
> +  if (IsReadableByteStreamReader(reader)) {
> +    for (const req of reader._readRequests) {
> +      req.resolve(CreateIterResultObject(undefined, true));
> +    }
> +
> +    reader._readRequests = [];
> +  } else {
> +    assert(IsReadableByteStreamByobReader(reader), 'reader must be ReadableByteStreamByobReader');
> +
> +    if (reader._readIntoRequests.length > 0) {
> +      return;

This needs a comment or something ... when you close a BYOB reader that has readInto requests, it doesn't get detached? Would it be better to not close it yet, and e.g. set closeRequested or something?

Apologies since this is probably something we discussed previously. It is complicated >_<

---
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/361/files#r33552907