W3C home > Mailing lists > Public > www-style@w3.org > May 2014

Re: [css-flexbox] Edits to testsuite have broken some submitted tests

From: Gérard Talbot <www-style@gtalbot.org>
Date: Thu, 22 May 2014 13:21:33 -0400
To: Daniel Holbert <dholbert@mozilla.com>
Cc: www-style <www-style@w3.org>
Message-ID: <7cfb51e8654336b2f462335981a4cc14@gtalbot.org>
Le 2014-05-22 13:07, Daniel Holbert a écrit :
> On 05/22/2014 09:56 AM, Gérard Talbot wrote:
>> In the following order:
>> 
>> - to test creators themselves [Addendum: that's you!!]
> 
> Yup! And I'm happy to do local fixes, if I can find the updated version
> of the file to fix. :)
> 
>> - to Public CSS Test suite mailing list
>> http://lists.w3.org/Archives/Public/public-css-testsuite/
> 
> Thanks -- I'll direct future similar questions there instead of to
> www-style.
> 
>> - to Peter Linss if you suspect some kind of XHTML-to-HTML
>> autoconversion issue or bug
> 
> OK. It sounds like that process might be what's involved here. Do these
> tests *need* to be HTML (not XHTML), by the way?
> 
>> I'm not 100% sure of your question (by live, I assume you mean the
>> latest and most recent version of tests originally submitted)
> 
> I'm asking where the files that I linked in my first message on this
> thread (and linked from the flexbox ED spec) are tracked / managed.
> 
> For reference, here's the link to one such file (in the testsuite):
> http://test.csswg.org/suites/css-flexbox-1_dev/nightly-unstable/html/reference/flexbox-align-self-vert-4-ref.htm
> 
> Note that this file ends in .htm, not .xhtml.
> 

One importantissimo detail.

If the src file is an XHTML file, then

<style type="text/css"><![CDATA[
     CSS FOR TEST
]]></style>

http://testthewebforward.org/docs/test-templates.html#including-styles

should be used so that problem-free XHTML-to-HTML autoconversion can be 
done.

Here's one possible problem in

http://test.csswg.org/shepherd/testcase/flexbox-align-self-vert-4/
:

line 15 <style>
line 16 .flexbox {
(...)
line 27 .flexbox > div {

The ">" at line 27 can or will most likely cause issues because it is 
not wrapped inside an
<![CDATA[
]]>
block .

>> but the src of tests
>> flexbox-align-self-vert-4.xhtml
> [...]
> 
>> http://test.csswg.org/source/contributors/mozilla/submitted/mozilla-central-reftests/
> 
> Right, those are the working .xhtml versions, not the converted/broken
> .htm versions. I'm looking for where the .htm versions were added &
> where *they* are tracked.

As I understand this, the .htm versions can not be tracked. There is 
only 1 src for all tests and they are converted into HTML4 and/or HTML5 
and/or XHTML1 versions.


One last remark. For conversion of tests into HTML4 or HTML5 or XHTML1 
versions, it is very important to follow and comply with Test Format 
guidelines.

In order to avoid unnecessary issues or problems (of various nature), it 
is best to follow and comply with Test Format guidelines.

The file name format is test-topic-###.ext
so I would be enclined to believe that

flexbox-align-self-vert-4.xhtml

is not best.

align-self-vert-004.xhtml

would be better.

Gérard

> 
>> Try
>> 
>> http://test.csswg.org/shepherd/testcase/flexbox-align-self-vert-4/
> 
> As above, this is the .xhtml version
> 
>> In Shepherd, you can view the change-history of tests.
> 
> That doesn't have the version of the test that I'm asking about, 
> though,
> so it doesn't have the changes that I'm interested in visible.
> 
> ~Daniel
Received on Thursday, 22 May 2014 17:22:08 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 22:51:27 UTC