- From: Shiozawa, Hajime <hajime.shiozawa@gmail.com>
- Date: Thu, 13 Aug 2015 18:49:38 +0900
- To: Gérard Talbot <css21testsuite@gtalbot.org>
- Cc: Public CSS test suite mailing list <public-css-testsuite@w3.org>, Koji Ishii <kojiishi@gluesoft.co.jp>
- Message-ID: <CAHSwuKMSUh4yOcgB9g8+1tRTtw+b-He6wFqHZpHzD+mwwY4m8Q@mail.gmail.com>
Gérard, done! Thank you :-) https://hg.csswg.org/test/rev/8a4235c97fa1 Hajime 2015-08-13 17:24 GMT+09:00 Gérard Talbot <css21testsuite@gtalbot.org>: > Le 2015-08-13 02:53, 塩澤 元 a écrit : > >> Gérard, >> >> Thank you for reviewing :-) >> >> I've fixed. >> https://hg.csswg.org/test/rev/ee1be7e5f943 >> >> Change Point >> - "/* computes to 60px */" is replaced with "/* computes to 60px/60px */" >> in all inline-[block | table]-alignment-00* >> - used "L" for last and "F" for first instead of "I" and "B". >> -- it is only for central baseline alignment tests because in alphabetical >> alignment test we should use "É". >> > > > Correct. > > >> Hajime. >> >> > Please add a > > <link rel="reviewer" title="Gérard Talbot" href=" > http://www.gtalbot.org/BrowserBugsSection/css21testsuite/" /> <!-- > 2015-08-13 --> > > into those 4 inline-table-alignment-00[2-5] tests. > > Gérard > > > >> 2015-08-13 6:45 GMT+09:00 Gérard Talbot <css21testsuite@gtalbot.org>: >> >> Le 2015-08-12 12:10, 塩澤 元 a écrit : >>> >>> Gérard, >>>> >>>> I've submitted a new tests for inline-table alignment. >>>> https://hg.csswg.org/test/rev/b7df87b05e86 >>>> >>>> I have created tests for only 'mixed' and 'upright' because you >>>> mentioned >>>> that it is better to do so only for this two properties.^[1] >>>> >>>> [1]: >>>> >>>> http://lists.w3.org/Archives/Public/public-css-testsuite/2015Jul/0035.html >>>> >>>> Hajime. >>>> >>>> >>> >>> inline-table alignment - central alignment with vertical layout >>> >>> >>> http://test.csswg.org/source/css-writing-modes-3/inline-table-alignment-002.xht >>> >>> >>> Proposed minor tunings for all 4 inline-table-alignment-00? tests >>> >>> font: 3.75em/1 Ahem; /* computes to 60px */ >>> >>> replaced with >>> >>> font: 3.75em/1 Ahem; /* computes to 60px/60px */ >>> >>> >>> <span class="row" id="last">B</span> >>> >>> replaced with >>> >>> <span class="row" id="last">T</span> >>> >>> >>> I am now thinking we should have been using "L" (for last) and "F" (for >>> first) instead of "I" and "B" in all inline-[block | table]-alignment-00? >>> tests so that the tests are easier to review with those more helpful, >>> meaningful characters. >>> >>> Overall, all 4 tests look excellent and they should be a good challenge >>> and meaningful testing for browser manufacturers. >>> >>> Gérard >>> -- >>> Test Format Guidelines >>> http://testthewebforward.org/docs/test-format-guidelines.html >>> >>> Test Style Guidelines >>> http://testthewebforward.org/docs/test-style-guidelines.html >>> >>> Test Templates >>> http://testthewebforward.org/docs/test-templates.html >>> >>> CSS Naming Guidelines >>> http://testthewebforward.org/docs/css-naming.html >>> >>> Test Review Checklist >>> http://testthewebforward.org/docs/review-checklist.html >>> >>> CSS Metadata >>> http://testthewebforward.org/docs/css-metadata.html >>> >>> > -- > Test Format Guidelines > http://testthewebforward.org/docs/test-format-guidelines.html > > Test Style Guidelines > http://testthewebforward.org/docs/test-style-guidelines.html > > Test Templates > http://testthewebforward.org/docs/test-templates.html > > CSS Naming Guidelines > http://testthewebforward.org/docs/css-naming.html > > Test Review Checklist > http://testthewebforward.org/docs/review-checklist.html > > CSS Metadata > http://testthewebforward.org/docs/css-metadata.html > -- # 塩澤 元 (Shiozawa, Hajime) # mail: hajime.shiozawa@gmail.com
Received on Thursday, 13 August 2015 09:50:07 UTC