Re: [css-flexbox] Edits to testsuite have broken some submitted tests

Also, while I'm at it:

 (c) the reference case for this test...

http://test.csswg.org/harness/test/css-flexbox-1_dev/

...seems to be missing. (clicking "Reference Page" and then "Show
reference" gives me a 404, failing to load this URL:
http://test.csswg.org/suites/css-flexbox-1_dev/nightly-unstable/html/flex-min-auto-rel.htm
)


 (d) This test uses -webkit prefixed CSS, without the corresponding
unprefixed CSS...
http://test.csswg.org/harness/test/css-flexbox-1_dev/flex-order/
...so it fails in non-webkit browsers.  It needs unprefixing.

(Unlike (a) and (b), neither of these tests were submitted by Mozilla;
I'm just mentioning them in this thread since I noticed their breakage
around the same time that I noticed the other breakage.)

Thanks,
~Daniel

On 05/21/2014 06:10 PM, Daniel Holbert wrote:
> Hi CSSWG,
> 
> I noticed some breaking changes that were made to some flexbox reftests
> that Mozilla has submitted to the Flexbox testsuite and which are
> publicly testable via the link at the top of the ED (
> http://dev.w3.org/csswg/css-flexbox/ ).  In particular, it looks like
> some test files have been auto-converted from .xhtml to .htm, and that
> process was imperfect & broke the rendering of some reference cases.
> 
> I'm not sure where to report these issues; hence, I'm reporting here. (I
> thought http://test.csswg.org/shepherd/ might be the place to report
> issues with the testsuite, but that server doesn't seem to know anything
> about these particular test files. ("No Assets Found", when I search for
> them by name.)  Moreover, a "find" command in my clone of
> http://hg.csswg.org/test doesn't find these files. So I'm not sure where
> they exist or where issues with them are tracked.)
> 
> The two specific issues I'd like to report for the moment are:
> 
>  (a) The reference case shown here...
> http://test.csswg.org/suites/css-flexbox-1_dev/nightly-unstable/html/reference/flexbox-align-self-vert-4-ref.htm
> ...doesn't have the light-blue "center" blocks centered, but it should.
> 
> For comparison, the submitted file looks like this:
> http://hg.mozilla.org/mozilla-central/raw-file/tip/layout/reftests/w3c-css/submitted/flexbox/flexbox-align-self-vert-4-ref.xhtml
> 
> The problem is that there's a <!-- --> comment in the <style> block,
> which is interpreted as a comment in XHTML but apparently not in HTML,
> and it neuters some style in the converted-to-HTML version.
> 
> 
>  (b) This reference case is just totally broken (should render with a
> bunch of baseline-aligned horizontal items):
> http://test.csswg.org/suites/css-flexbox-1_dev/nightly-unstable/html/reference/flexbox-align-self-baseline-horiz-1-ref.htm
> 
> For comparison, the submitted file looks like this:
> http://hg.mozilla.org/mozilla-central/raw-file/tip/layout/reftests/w3c-css/submitted/flexbox/flexbox-align-self-baseline-horiz-1-ref.xhtml
> 
> (Again, this seems to be from an XHTML-to-HTML autoconversion problem.)
> 
> 
> Thanks,
> ~Daniel
>

Received on Thursday, 22 May 2014 01:25:32 UTC