Re: [w3c/gamepad] Add trigger rumble effect (PR #195)

@nondebug commented on this pull request.



>              {{GamepadEffectParameters/strongMagnitude}} and the
             {{GamepadEffectParameters/weakMagnitude}} must be in the range
             `[0,1]`.
           </p>
         </dd>
+        <dt>
+          <dfn data-for="GamepadHapticEffectType">"trigger-rumble" effect
+          type</dfn>
+        </dt>
+        <dd>
+          <p>
+            {{GamepadHapticEffectType/"trigger-rumble"}} describes a haptics
+            configuration with a vibration motor in each of the bottom front buttons
+            of a [=Standard Gamepad=] (buttons with [=canonical indexes=] 6 and 7) in addition to the two handle motors used for 

Both "indexes" and "indices" are valid plurals for "index", but we should choose one and use it consistently within the spec. "Indices" is already used elsewhere in the spec so I think we should prefer `[=canonical indices=]` here.

>              {{GamepadEffectParameters/strongMagnitude}} and the
             {{GamepadEffectParameters/weakMagnitude}} must be in the range
             `[0,1]`.
           </p>
         </dd>
+        <dt>
+          <dfn data-for="GamepadHapticEffectType">"trigger-rumble" effect
+          type</dfn>
+        </dt>
+        <dd>
+          <p>
+            {{GamepadHapticEffectType/"trigger-rumble"}} describes a haptics
+            configuration with a vibration motor in each of the bottom front buttons
+            of a [=Standard Gamepad=] (buttons with [=canonical indexes=] 6 and 7) in addition to the two handle motors used for 
+            {{GamepadHapticEffectType/"dual-rumble"}}. Nowadays these buttons
+            most-commonly take the form of spring-loaded triggers. In this

"most commonly" (no dash)

> +            {{GamepadEffectParameters/strongMagnitude}},
+            {{GamepadEffectParameters/weakMagnitude}}, {{GamepadEffectParameters/leftTrigger}}, and {{GamepadEffectParameters/rightTrigger}}, none of which are
+            required because they default to 0.
+          </p>
+          <p>
+            {{GamepadEffectParameters/startDelay}}, {{GamepadEffectParameters/duration}},
+            {{GamepadEffectParameters/strongMagnitude}},
+            {{GamepadEffectParameters/weakMagnitude}} share the same definition with {{GamepadHapticEffectType/"dual-rumble"}}.
+            {{GamepadEffectParameters/leftTrigger}} and
+            {{GamepadEffectParameters/rightTrigger}}, respectively, set the
+            intensity levels for the left and right bottom front buttons
+            vibrations, normalized to the range `[0,1]`, defaulting to 0.
+          </p>
+          <p>
+            Given {{GamepadEffectParameters}} |params:GamepadEffectParameters|,
+            a <dfn>valid trigger-rumble effect</dfn> must have a valid

Please update the definition of "valid effect" to also check for valid trigger-rumble effects. (Currently it only checks dual-rumble and will always consider trigger-rumble effects valid.)

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/gamepad/pull/195#pullrequestreview-1937935083
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/gamepad/pull/195/review/1937935083@github.com>