Re: [w3c/gamepad] Add trigger rumble effect (PR #195)

@gabrielsanbrito commented on this pull request.



> +            {{GamepadEffectParameters/strongMagnitude}},
+            {{GamepadEffectParameters/weakMagnitude}}, {{GamepadEffectParameters/leftTrigger}}, and {{GamepadEffectParameters/rightTrigger}}, none of which are
+            required because they default to 0.
+          </p>
+          <p>
+            {{GamepadEffectParameters/startDelay}}, {{GamepadEffectParameters/duration}},
+            {{GamepadEffectParameters/strongMagnitude}},
+            {{GamepadEffectParameters/weakMagnitude}} share the same definition with {{GamepadHapticEffectType/"dual-rumble"}}.
+            {{GamepadEffectParameters/leftTrigger}} and
+            {{GamepadEffectParameters/rightTrigger}}, respectively, set the
+            intensity levels for the left and right bottom front buttons
+            vibrations, normalized to the range `[0,1]`, defaulting to 0.
+          </p>
+          <p>
+            Given {{GamepadEffectParameters}} |params:GamepadEffectParameters|,
+            a <dfn>valid trigger-rumble effect</dfn> must have a valid

@marcoscaceres like below? Should I also add it inside the `dfn` tag? `<dfn>[=valid effect|valid=] trigger-rumble effect</dfn>`
```html
Given {{GamepadEffectParameters}} |params:GamepadEffectParameters|,
a <dfn>[=valid effect|valid=] trigger-rumble effect</dfn> must have a [=valid effect|valid=]
{{GamepadEffectParameters/duration}}, a [=valid effect|valid=] {{GamepadEffectParameters/startDelay}}, and the
{{GamepadEffectParameters/strongMagnitude}},
{{GamepadEffectParameters/weakMagnitude}}, {{GamepadEffectParameters/leftTrigger}}, and {{GamepadEffectParameters/rightTrigger}} must be in the range `[0,1]`.
```

btw, `[=valid effect|valid=]` works.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/gamepad/pull/195#discussion_r1542334170
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/gamepad/pull/195/review/1965198159@github.com>

Received on Thursday, 28 March 2024 05:26:32 UTC