- From: Anne van Kesteren <notifications@github.com>
- Date: Thu, 12 Dec 2024 09:31:07 -0800
- To: whatwg/dom <dom@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/dom/pull/1334@github.com>
Strictly speaking this should be an editorial change, but as it's fairly significant not marking it as such. This improves integration with HTML as well. As part of this change we move the shadow tree behavior under creating the element clone as that is a more logical fit. Unfortunately subtree has to be passed everywhere as HTML needs it for its template element logic. That's also why clone a node's children is exported. Corresponding HTML PR: SOON. Fixes #1219. Closes #1220. <!-- Thank you for contributing to the DOM Standard! Please describe the change you are making and complete the checklist below if your change is not editorial. When you submit this PR, and each time you edit this comment (including checking a checkbox through the UI!), PR Preview will run and update it. As such make any edits in one go and only after PR Preview has run. If you think your PR is ready to land, please double-check that the build is passing and the checklist is complete before pinging. --> - [ ] At least two implementers are interested (and none opposed): * … * … - [ ] [Tests](https://github.com/web-platform-tests/wpt) are written and can be reviewed and commented upon at: * … <!-- If these tests are tentative, link a PR to make them non-tentative. --> - [ ] [Implementation bugs](https://github.com/whatwg/meta/blob/main/MAINTAINERS.md#handling-pull-requests) are filed: * Chromium: … * Gecko: … * WebKit: … * Deno (only for aborting and events): … * Node.js (only for aborting and events): … - [ ] [MDN issue](https://github.com/whatwg/meta/blob/main/MAINTAINERS.md#handling-pull-requests) is filed: … - [ ] The top of this comment includes a [clear commit message](https://github.com/whatwg/meta/blob/main/COMMITTING.md) to use. <!-- If you created this PR from a single commit, Github copied its message. Otherwise, you need to add a commit message yourself. --> (See [WHATWG Working Mode: Changes](https://whatwg.org/working-mode#changes) for more details.) You can view, comment on, or merge this pull request online at: https://github.com/whatwg/dom/pull/1334 -- Commit Summary -- * Remove quadratic behavior from clone a node -- File Changes -- M dom.bs (135) -- Patch Links -- https://github.com/whatwg/dom/pull/1334.patch https://github.com/whatwg/dom/pull/1334.diff -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/dom/pull/1334 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/dom/pull/1334@github.com>
Received on Thursday, 12 December 2024 17:31:11 UTC