Re: [whatwg/dom] Remove quadratic behavior from clone a node (PR #1334)

@dbaron approved this pull request.

Sorry for the delay getting to this.  This looks good to me except for a single sentence (see below).

>   <var>document</var>.
 
+ <li><p>If <var>parent</var> is non-null, then <a for=/>append</a> <var>copy</var> to
+ <var>parent</var>.
+
+ <li><p>Run any <a>cloning steps</a> defined for <var>node</var> in
+ <a>other applicable specifications</a> and pass <var>node</var>, <var>copy</var>, and
+ <var>subtree</var> as parameters.
+
+ <li><p>If <var>subtree</var> is true, then for each <var>child</var> of <var>node</var>'s
+ <a for=tree>children</a>, in <a>tree order</a>: <a>clone a node</a> given <var>child</var> with
+ <a for="clone a node"><i>document</i></a> set to <var>document</var>,
+ <a for="clone a node"><i>subtree</i></a> set to <var>subtree</var>, and
+ <a for="clone a node"><i>parent</i></a> set to <var>copy</var>.
+
+ <li>
+  <p>If <var>node</var> is an <a for=/>element</a>, <a for=Element>shadow host</a>, and its

This insertion of "an element" makes the clause not really seem to parse properly (as English) anymore.  I'm not quite sure what the change relative to the old wording was intended to be, but I can't tell what the new wording means.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/1334#pullrequestreview-2506764230
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/dom/pull/1334/review/2506764230@github.com>