Re: [whatwg/dom] Remove quadratic behavior from clone a node (PR #1334)

@annevk commented on this pull request.



>   <var>document</var>.
 
+ <li><p>If <var>parent</var> is non-null, then <a for=/>append</a> <var>copy</var> to
+ <var>parent</var>.
+
+ <li><p>Run any <a>cloning steps</a> defined for <var>node</var> in
+ <a>other applicable specifications</a> and pass <var>node</var>, <var>copy</var>, and
+ <var>subtree</var> as parameters.
+
+ <li><p>If <var>subtree</var> is true, then for each <var>child</var> of <var>node</var>'s
+ <a for=tree>children</a>, in <a>tree order</a>: <a>clone a node</a> given <var>child</var> with
+ <a for="clone a node"><i>document</i></a> set to <var>document</var>,
+ <a for="clone a node"><i>subtree</i></a> set to <var>subtree</var>, and
+ <a for="clone a node"><i>parent</i></a> set to <var>copy</var>.
+
+ <li>
+  <p>If <var>node</var> is an <a for=/>element</a>, <a for=Element>shadow host</a>, and its

Thanks for the review!

I guess I'll change it to:

> If _node_ is an element, _node_ is a shadow host, and _node_'s shadow root's clonable is true

The problem is that "is a shadow host" is only defined for elements.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/1334#discussion_r1887185373
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/dom/pull/1334/review/2506780774@github.com>