Re: [whatwg/dom] Remove quadratic behavior from clone a node (PR #1334)

@annevk commented on this pull request.



> +  <ol>
+   <li><p><a for=/>Assert</a>: <var>copy</var> is not a <a for=Element>shadow host</a>.
+
+   <li><p><a>Attach a shadow root</a> with <var>copy</var>, <var>node</var>'s
+   <a for=Element>shadow root</a>'s <a for=ShadowRoot>mode</a>, true, <var>node</var>'s
+   <a for=Element>shadow root</a>'s <a for=ShadowRoot>serializable</a>, <var>node</var>'s
+   <a for=Element>shadow root</a>'s <a for=ShadowRoot>delegates focus</a>, and <var>node</var>'s
+   <a for=Element>shadow root</a>'s <a for=ShadowRoot>slot assignment</a>.
+
+   <li><p>Set <var>copy</var>'s <a for=Element>shadow root</a>'s <a for=ShadowRoot>declarative</a>
+   to <var>node</var>'s <a for=Element>shadow root</a>'s <a for=ShadowRoot>declarative</a>.
+
+   <li><p>For each <var>child</var> of <var>node</var>'s <a for=Element>shadow root</a>'s
+   <a for=tree>children</a>, in <a>tree order</a>: <a>clone a node and append</a> given
+   <var>child</var>, <var>copy</var>'s <a for=Element>shadow root</a>, <var>document</var>, and
+   <var>subtree</var>.

Yeah it is, but is that the result of cloning order or something else? As per the discussion in #695 there's already a difference between engines.

I can restore the original order here though. That seems better for now either way.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/1334#discussion_r1884845535
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/dom/pull/1334/review/2503605653@github.com>