Re: [w3c/ServiceWorker] Adding self.serviceWorker to service workers. (#1426)

mattto approved this pull request.

This looks great... if it's not too much of a hassle, it might also be worth splitting this into two PRs: one with the "getting the service worker object" algorithm and one that adds self.serviceWorker. For self.serviceWorker, it might be worth pinging the issue or here for more visibility?

> @@ -1084,7 +1106,7 @@ spec: webappsec-referrer-policy; urlPrefix: https://w3c.github.io/webappsec-refe
             1. Let |destination| be the {{ServiceWorkerContainer}} object whose associated [=ServiceWorkerContainer/service worker client=] is |targetClient|.
             1. Add a [=task=] that runs the following steps to |destination|'s [=ServiceWorkerContainer/client message queue=]:
                 1. Let |origin| be the [=Unicode serialization of an origin|Unicode serialization=] of |sourceSettings|'s [=environment settings object/origin=].
-                1. Let |source| be a {{ServiceWorker}} object, which represents the [=ServiceWorkerGlobalScope/service worker=] associated with |sourceSettings|'s [=environment settings object/global object=].
+                1. Let |source| be the result of [=getting the service worker object=] that represents |sourceSettings|'s [=environment settings object/global object=]'s [=ServiceWorkerGlobalScope/service worker=] in |targetClient|.

I'm still wrapping my head around Realms, settings objects, etc, so a naive question: is there a more direct way to get to the service worker? It looks like we're doing [=context object=]'s [=relevant settings object=]'s [=global object=]'s service worker. Is it equivalent to do [=context object=]'s [=relevant global object=]'s service worker, or is that something else?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/ServiceWorker/pull/1426#pullrequestreview-247103885