- From: Jake Archibald <notifications@github.com>
- Date: Fri, 07 Jun 2019 07:32:34 -0700
- To: w3c/ServiceWorker <ServiceWorker@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/ServiceWorker/pull/1426/review/247130090@github.com>
jakearchibald commented on this pull request. > @@ -1084,7 +1106,7 @@ spec: webappsec-referrer-policy; urlPrefix: https://w3c.github.io/webappsec-refe 1. Let |destination| be the {{ServiceWorkerContainer}} object whose associated [=ServiceWorkerContainer/service worker client=] is |targetClient|. 1. Add a [=task=] that runs the following steps to |destination|'s [=ServiceWorkerContainer/client message queue=]: 1. Let |origin| be the [=Unicode serialization of an origin|Unicode serialization=] of |sourceSettings|'s [=environment settings object/origin=]. - 1. Let |source| be a {{ServiceWorker}} object, which represents the [=ServiceWorkerGlobalScope/service worker=] associated with |sourceSettings|'s [=environment settings object/global object=]. + 1. Let |source| be the result of [=getting the service worker object=] that represents |sourceSettings|'s [=environment settings object/global object=]'s [=ServiceWorkerGlobalScope/service worker=] in |targetClient|. Yeah, that's fair, I'll switch to that. I think it means adding `1. Let |contextObject| be the [=context object=].` at the start, since I don't think you can access the context object once you're in parallel. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/ServiceWorker/pull/1426#discussion_r291618722
Received on Friday, 7 June 2019 14:32:56 UTC