W3C home > Mailing lists > Public > public-data-shapes-wg@w3.org > January 2016

Re: problem with test suite harness

From: Holger Knublauch <holger@topquadrant.com>
Date: Tue, 12 Jan 2016 12:13:39 +1000
To: public-data-shapes-wg@w3.org
Message-ID: <56946153.8030300@topquadrant.com>
Thanks, Peter. The second branch of the if was indeed incorrect (copy 
and paste error - undetected as none of my tests is of that format). The 
first branch seems semantically equivalent but I made the code more 
readable.

https://github.com/TopQuadrant/shacl/commit/84c7499db34c23a0527c65c83738e79391b7d6f6

Holger


On 12/01/2016 3:57 AM, Peter F. Patel-Schneider wrote:
> The first two branches of compareResults in AbstractSHACLTestClass appear to
> be incorrect and should read more like
>
>
> 	protected void compareResults(Model results) {
> 		String printed = ModelPrinter.get().print(results);
> 		Statement resultS = testResource.getProperty(MF.result);
> 		if(resultS == null || JenaDatatypes.TRUE.equals(resultS.getObject())) {
> 			if ( results.size() > 0 ) {
> 				fail("Validation was not expected to produce any results for " +
> testResource);
> 			}
> 		}
> 		else if(testResource.hasProperty(MF.result, SHT.Failure)) {
> 		    if(!results.contains(null, SH.severity, SH.Violation)) {
> 				fail("Validation was expected to produce failure for " + testResource);
> 			}
> 		}
> 		else {
Received on Tuesday, 12 January 2016 02:14:16 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 19:30:29 UTC