W3C home > Mailing lists > Public > public-data-shapes-wg@w3.org > January 2016

problem with test suite harness

From: Peter F. Patel-Schneider <pfpschneider@gmail.com>
Date: Mon, 11 Jan 2016 09:57:13 -0800
To: Holger Knublauch <holger@topquadrant.com>, public-data-shapes-wg@w3.org
Message-ID: <5693ECF9.9050405@gmail.com>
The first two branches of compareResults in AbstractSHACLTestClass appear to
be incorrect and should read more like


	protected void compareResults(Model results) {
		String printed = ModelPrinter.get().print(results);
		Statement resultS = testResource.getProperty(MF.result);
		if(resultS == null || JenaDatatypes.TRUE.equals(resultS.getObject())) {
			if ( results.size() > 0 ) {
				fail("Validation was not expected to produce any results for " +
testResource);
			}
		}
		else if(testResource.hasProperty(MF.result, SHT.Failure)) {
		    if(!results.contains(null, SH.severity, SH.Violation)) {
				fail("Validation was expected to produce failure for " + testResource);
			}
		}
		else {
Received on Monday, 11 January 2016 17:57:45 UTC

This archive was generated by hypermail 2.4.0 : Friday, 17 January 2020 19:30:29 UTC