- From: Gérard Talbot <css21testsuite@gtalbot.org>
- Date: Sat, 03 Jan 2015 16:23:36 -0500
- To: Manuel Rego Casasnovas <rego@igalia.com>
- Cc: Public CSS Test suite mailing list <public-css-testsuite@w3.org>
Le 2015-01-03 15:10, Gérard Talbot a écrit :
> Le 2014-12-18 07:01, Manuel Rego Casasnovas a écrit :
>> Hi Gérard,
>>
>> following the line of the previous tests, I've 4 new tests to check
>> that
>> "float" and "clear" properties don't apply to grid items.
>>
>
> Rego,
>
> Sorry for the long delay.
>
>>
>> * grid-float-001:
>> * Source:
>> https://github.com/mrego/csswg-test/blob/css-grid-float-clear-tests/css-grid-1/grid-model/grid-float-001.xht
>> * View:
>> https://rawgit.com/mrego/csswg-test/css-grid-float-clear-tests/css-grid-1/grid-model/grid-float-001.xht
>
> 1-
> The meta assert more or less repeats what is already given in the
> title element. So, you could skip the meta assert here.
> This issue has been happening in a few of your other tests too.
>
> 2-
> You may want to create a variant of such test, say, grid-float-002
> where the code would be
> <div class="grid">
> <div class="test-overlapping-green float-left"></div>
> <div class="test-overlapping-green float-left"></div>
> </div>
>
> 3-
> You may also want to create another variant of such test where the
> left-floating box would have content, say,
> grid-float-003
>
> <meta content="ahem" name="flags" />
>
> (...)
> .grid {
> display: grid;
> font: 1.25em/2.5 Ahem; /* computes to 20px/50px */
> }
>
> .test-overlapping-green {
> background-color: green;
> }
>
> .float-left {
> float: left;
> }
>
> (...)
>
> <div class="grid">
> <div class="test-overlapping-green float-left">FLOAT</div>
> <div class="test-overlapping-green">NotFL</div>
> </div>
>
> 4-
> You may also want to create another variant of such test where the 2
> left-floating boxes have content, say,
> grid-float-004
>
> <meta content="ahem" name="flags" />
>
> (...)
>
>
> .grid {
> display: grid;
> font: 1.25em/2.5 Ahem; /* computes to 20px/50px */
> }
>
> .test-overlapping-green {
> background-color: green;
> }
>
> .float-left {
> float: left;
> }
>
> (...)
>
> <div class="grid">
> <div class="test-overlapping-green float-left">FLOAT</div>
> <div class="test-overlapping-green float-left">FLOAT</div>
> </div>
>
>
> 5-
> You may also want to create another variant of such test where the 2
> left-floating boxes have not-filling content, say,
> grid-float-005
>
> <meta content="ahem" name="flags" />
>
> (...)
>
>
> .grid {
> display: grid;
> font: 1.25em/2.5 Ahem; /* computes to 20px/50px */
> }
>
> .test-overlapping-green {
> background-color: green;
> }
>
> .float-left {
> float: left;
> }
>
> (...)
>
> <div class="grid">
> <div class="test-overlapping-green float-left">FL</div>
> <div class="test-overlapping-green float-left">FLO</div>
> </div>
>
>
> 6-
> You may also want to create another variant of such test where the 1
> (or 2) left-floating box(es) have not-filling content, say,
> grid-float-006
>
> .grid {
> display: grid;
> font: 1.25em/2.5 Ahem; /* computes to 20px/50px */
> }
>
> .test-overlapping-green {
> background-color: green;
> }
>
> .float-left {
> float: left;
> }
>
> (...)
>
> <div class="grid">
> <div class="test-overlapping-green float-left">FLO</div>
> <div class="test-overlapping-green">NF</div>
> </div>
>
Rego,
I just noticed today your
http://test.csswg.org/source/css-grid-1/test-plan/index.html
document... so maybe all I wrote was not needed or already planned by
you.
>
>
>>
>> * grid-inline-float-001:
>> * Source:
>> https://github.com/mrego/csswg-test/blob/css-grid-float-clear-tests/css-grid-1/grid-model/grid-inline-float-001.xht
>> * View:
>> https://rawgit.com/mrego/csswg-test/css-grid-float-clear-tests/css-grid-1/grid-model/grid-inline-float-001.xht
>>
>
> Same points as above for grid-inline-float-001 test.
>
>> * grid-clear-001:
>> * Source:
>> https://github.com/mrego/csswg-test/blob/css-grid-float-clear-tests/css-grid-1/grid-model/grid-clear-001.xht
>> * View:
>> https://rawgit.com/mrego/csswg-test/css-grid-float-clear-tests/css-grid-1/grid-model/grid-clear-001.xht
>
> If 'float' does not apply to grid and inline-grid elements, then how
> is it possible and realistic
<ins> to expect </ins>
> that 'clear' could (or possibly would)
> have a rendering effect on grid and inline grid elements? And so, why
> would there be a need or justification to test 'clear' property?
>
> The safest policy would be to do those
<ins> grid versus clear </ins>
> tests. Doing those tests
> (Arron Eicholz policy) would make the coverageability of the test
> suite more complete, thorough.
---------
Other possible /support images which you may find useful to reuse for
creating future grid tests:
pattern-* images:
http://test.csswg.org/source/css21/support/pattern-gg-gr-100x100.png
http://test.csswg.org/source/support/pattern-grg-rgr-grg.png
http://test.csswg.org/source/support/pattern-grg-rrg-rgg.png
http://test.csswg.org/source/support/pattern-rgr-grg-rgr.png
http://test.csswg.org/source/support/pattern-tr.png
and maybe
http://test.csswg.org/source/css21/support/transparent_green.png
If you use them, then you would need to create a
http://test.csswg.org/source/css-grid-1/grid-model/support/
folder and then hg-copy those pattern-* images into such
/css-grid-1/grid-model/support/ folder.
Another /support image which could be possibly useful to reuse for your
grid tests:
http://test.csswg.org/source/css21/support/transparent_green.png
Gérard
--
Test Format Guidelines
http://testthewebforward.org/docs/test-format-guidelines.html
Test Style Guidelines
http://testthewebforward.org/docs/test-style-guidelines.html
Test Templates
http://testthewebforward.org/docs/test-templates.html
CSS Naming Guidelines
http://testthewebforward.org/docs/css-naming.html
Test Review Checklist
http://testthewebforward.org/docs/review-checklist.html
CSS Metadata
http://testthewebforward.org/docs/css-metadata.html
Received on Saturday, 3 January 2015 21:24:15 UTC