W3C home > Mailing lists > Public > public-css-testsuite@w3.org > January 2015

Re: [css-grid] grid-float-001, grid-inline-float-001, grid-clear-001 and grid-inline-clear-001: review request

From: Gérard Talbot <css21testsuite@gtalbot.org>
Date: Sat, 03 Jan 2015 15:10:16 -0500
To: Manuel Rego Casasnovas <rego@igalia.com>
Cc: Public CSS Test suite mailing list <public-css-testsuite@w3.org>
Message-ID: <d3a00e5afd37a6b611ee5149c2a29d70@gtalbot.org>
Le 2014-12-18 07:01, Manuel Rego Casasnovas a écrit :
> Hi Gérard,
> 
> following the line of the previous tests, I've 4 new tests to check 
> that
> "float" and "clear" properties don't apply to grid items.
> 

Rego,

Sorry for the long delay.

> 
> * grid-float-001:
>   * Source:
> https://github.com/mrego/csswg-test/blob/css-grid-float-clear-tests/css-grid-1/grid-model/grid-float-001.xht
>   * View:
> https://rawgit.com/mrego/csswg-test/css-grid-float-clear-tests/css-grid-1/grid-model/grid-float-001.xht

1-
The meta assert more or less repeats what is already given in the title 
element. So, you could skip the meta assert here.
This issue has been happening in a few of your other tests too.

2-
You may want to create a variant of such test, say, grid-float-002 where 
the code would be
<div class="grid">
             <div class="test-overlapping-green float-left"></div>
             <div class="test-overlapping-green float-left"></div>
         </div>

3-
You may also want to create another variant of such test where the 
left-floating box would have content, say,
grid-float-003

   <meta content="ahem" name="flags" />

(...)
             .grid {
                 display: grid;
                 font: 1.25em/2.5 Ahem; /* computes to 20px/50px */
             }

.test-overlapping-green {
                 background-color: green;
             }

             .float-left {
                 float: left;
             }

(...)

<div class="grid">
             <div class="test-overlapping-green float-left">FLOAT</div>
             <div class="test-overlapping-green">NotFL</div>
         </div>

4-
You may also want to create another variant of such test where the 2 
left-floating boxes have content, say,
grid-float-004

   <meta content="ahem" name="flags" />

(...)


             .grid {
                 display: grid;
                 font: 1.25em/2.5 Ahem; /* computes to 20px/50px */
             }

.test-overlapping-green {
                 background-color: green;
             }

             .float-left {
                 float: left;
             }

(...)

<div class="grid">
             <div class="test-overlapping-green float-left">FLOAT</div>
             <div class="test-overlapping-green float-left">FLOAT</div>
         </div>


5-
You may also want to create another variant of such test where the 2 
left-floating boxes have not-filling content, say,
grid-float-005

   <meta content="ahem" name="flags" />

(...)


             .grid {
                 display: grid;
                 font: 1.25em/2.5 Ahem; /* computes to 20px/50px */
             }

.test-overlapping-green {
                 background-color: green;
             }

             .float-left {
                 float: left;
             }

(...)

<div class="grid">
             <div class="test-overlapping-green float-left">FL</div>
             <div class="test-overlapping-green float-left">FLO</div>
         </div>


6-
You may also want to create another variant of such test where the 1 (or 
2) left-floating box(es) have not-filling content, say,
grid-float-006

             .grid {
                 display: grid;
                 font: 1.25em/2.5 Ahem; /* computes to 20px/50px */
             }

.test-overlapping-green {
                 background-color: green;
             }

             .float-left {
                 float: left;
             }

(...)

<div class="grid">
             <div class="test-overlapping-green float-left">FLO</div>
             <div class="test-overlapping-green">NF</div>
         </div>



> 
> * grid-inline-float-001:
>   * Source:
> https://github.com/mrego/csswg-test/blob/css-grid-float-clear-tests/css-grid-1/grid-model/grid-inline-float-001.xht
>   * View:
> https://rawgit.com/mrego/csswg-test/css-grid-float-clear-tests/css-grid-1/grid-model/grid-inline-float-001.xht
> 

Same points as above for grid-inline-float-001 test.

> * grid-clear-001:
>   * Source:
> https://github.com/mrego/csswg-test/blob/css-grid-float-clear-tests/css-grid-1/grid-model/grid-clear-001.xht
>   * View:
> https://rawgit.com/mrego/csswg-test/css-grid-float-clear-tests/css-grid-1/grid-model/grid-clear-001.xht

If 'float' does not apply to grid and inline-grid elements, then how is 
it possible and realistic that 'clear' could (or possibly would) have a 
rendering effect on grid and inline grid elements? And so, why would 
there be a need or justification to test 'clear' property?

The safest policy would be to do those tests. Doing those tests  (Arron 
Eicholz policy) would make the coverageability of the test suite more 
complete, thorough.

Gérard

> 
> * grid-inline-clear-001:
>   * Source:
> https://github.com/mrego/csswg-test/blob/css-grid-float-clear-tests/css-grid-1/grid-model/grid-inline-clear-001.xht
>   * View:
> https://rawgit.com/mrego/csswg-test/css-grid-float-clear-tests/css-grid-1/grid-model/grid-inline-clear-001.xht
> 
> 
> Thank you very much,
>   Rego

-- 
Test Format Guidelines
http://testthewebforward.org/docs/test-format-guidelines.html

Test Style Guidelines
http://testthewebforward.org/docs/test-style-guidelines.html

Test Templates
http://testthewebforward.org/docs/test-templates.html

CSS Naming Guidelines
http://testthewebforward.org/docs/css-naming.html

Test Review Checklist
http://testthewebforward.org/docs/review-checklist.html

CSS Metadata
http://testthewebforward.org/docs/css-metadata.html
Received on Saturday, 3 January 2015 20:10:53 UTC

This archive was generated by hypermail 2.4.0 : Friday, 20 January 2023 19:58:20 UTC