- From: Gérard Talbot <css21testsuite@gtalbot.org>
- Date: Sun, 11 Jul 2010 13:05:58 -0700
- To: "public-css-testsuite@w3.org" <public-css-testsuite@w3.org>
- Cc: "Arron Eicholz" <Arron.Eicholz@microsoft.com>
Hello all,
Here's my review report of testcases in chapter 18:
http://test.csswg.org/suites/css2.1/20100701/html4/chapter-18.html
Arron
-----
100% of this report regards exclusively to Microsoft submitted
testcases. Most of the time, it's about out-of-range value for rgb(),
small inaccuracies, better wording of expected results (what's a wait
cursor, progress cursor) or steps to execute (how to activate text?,
focus text?), etc.
The 3 following have more important problems IMO:
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-058.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-078.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-layout-002.htm
==============
Reviewed and approved:
http://test.csswg.org/suites/css2.1/20100701/html4/cursor-001.htm
http://test.csswg.org/suites/css2.1/20100701/html4/cursor-002.htm
http://test.csswg.org/suites/css2.1/20100701/html4/cursor-003.htm
http://test.csswg.org/suites/css2.1/20100701/html4/cursor-004.htm
---------------
Rejected:
http://test.csswg.org/suites/css2.1/20100701/html4/cursor-005.htm
<meta name="assert" content="Cursor 'pointer' results in a cursor that
indicates
an element can be clicked.">
"indicates an element can be clicked" (current assertion)
versus
"indicates a link" (spec)
Even when hovering the cursor over an <img onclick="...some
function...">, a push button, a radio button, a checkbox, the cursor
under Windows does not change into a pointer but remains an arrow.
The pointer cursor is to indicate a link and not any/all clickable
objects. It's because web authors abuse cursor declaration or misuse
cursor declaration that there is a tendency to generalize or assume
things (like a cursor revealing clickability) that the spec does not
say.
Proposed suggestion:
<meta name="assert" content="Cursor 'pointer' results in a cursor that
indicates a link.">
-----------------------
Reviewed and approved:
http://test.csswg.org/suites/css2.1/20100701/html4/cursor-006.htm
http://test.csswg.org/suites/css2.1/20100701/html4/cursor-007.htm
http://test.csswg.org/suites/css2.1/20100701/html4/cursor-008.htm
http://test.csswg.org/suites/css2.1/20100701/html4/cursor-009.htm
http://test.csswg.org/suites/css2.1/20100701/html4/cursor-010.htm
http://test.csswg.org/suites/css2.1/20100701/html4/cursor-011.htm
http://test.csswg.org/suites/css2.1/20100701/html4/cursor-012.htm
http://test.csswg.org/suites/css2.1/20100701/html4/cursor-013.htm
http://test.csswg.org/suites/css2.1/20100701/html4/cursor-014.htm
http://test.csswg.org/suites/css2.1/20100701/html4/cursor-015.htm
<meta name="assert" content="Cursor 'text' results in a cursor that
indicates user can select or input text.">
When hovering over a text input, the cursor is an I-beam. Once clicked
inside such text input, then the blinking caret appears.
Mac OS X says "Selecting and inserting text."
http://developer.apple.com/mac/library/documentation/UserExperience/Conceptual/
AppleHIGuidelines/XHIGCursors/XHIGCursors.html#//apple_ref/doc/uid/TP40002724-
TPXREF101
Regardless, the spec only says:
{
text
Indicates text that may be selected. Often rendered as an I-beam.
}
Ideally, the spec would have to be updated to reflect this and a
testcase should be done with, say, an input type="text" or textarea
So: reviewed and approved.
------------------------
Rejected:
http://test.csswg.org/suites/css2.1/20100701/html4/cursor-016.htm
Why not describe how such wait cursor may look?
"Often rendered as a watch or hourglass. "
Proposed suggestion:
<p>Test passes if a wait cursor appears when the mouse cursor is inside
the blue box. Such wait cursor often resembles a watch or hourglass.</p>
----------------------
Rejected:
http://test.csswg.org/suites/css2.1/20100701/html4/cursor-017.htm
Proposed suggestion:
<p>Test passes if a help cursor appears when the mouse cursor is inside
the blue box. Such help cursor often resembles a question mark or a
balloon.</p>
----------------------
Rejected:
http://test.csswg.org/suites/css2.1/20100701/html4/cursor-018.htm
<meta name="assert" content="Cursor 'progress' results in a cursor that
indicates something is in progression.">
<p>Test passes if a progress cursor appears when the mouse cursor is
inside the blue box.</p>
{
progress
A progress indicator. The program is performing some processing, but
is different from 'wait' in that the user may still interact with
the program. Often rendered as a spinning beach ball, or an arrow
with a watch or hourglass.
}
Rejected. You and I know what's a progress cursor, a wait cursor and how
they are differ from each other; my neighbour/bus driver/mother/roommate
after trying those 2 testcases would not be sure of this or would not
know.
Proposed suggestion:
<p>Test passes if a progress cursor appears when the mouse cursor is
inside the blue box. Such progress cursor often resembles a spinning
beach ball or an arrow with a watch or an arrow with an hourglass.</p>
-------------------
Approved:
http://test.csswg.org/suites/css2.1/20100701/html4/cursor-019.htm
-------------
Approved:
http://test.csswg.org/suites/css2.1/20100701/html4/cursor-applies-to-001.htm
http://test.csswg.org/suites/css2.1/20100701/html4/cursor-applies-to-002.htm
http://test.csswg.org/suites/css2.1/20100701/html4/cursor-applies-to-003.htm
http://test.csswg.org/suites/css2.1/20100701/html4/cursor-applies-to-004.htm
http://test.csswg.org/suites/css2.1/20100701/html4/cursor-applies-to-005.htm
http://test.csswg.org/suites/css2.1/20100701/html4/cursor-applies-to-006.htm
http://test.csswg.org/suites/css2.1/20100701/html4/cursor-applies-to-007.htm
http://test.csswg.org/suites/css2.1/20100701/html4/cursor-applies-to-008.htm
http://test.csswg.org/suites/css2.1/20100701/html4/cursor-applies-to-009.htm
------------
Rejected:
http://test.csswg.org/suites/css2.1/20100701/html4/cursor-applies-to-010.htm
The testcase should allocated a margin-left of 1em for the list-marker
(bullet):
Suggested modification:
<style type="text/css">
div
{
background-color: blue;
cursor: pointer;
display: list-item;
height: 1in;
margin-left: 1em;
width: 1in;
}
</style>
<p>Test passes if the cursor changes to a pointer cursor when it
is over the blue area. The blue square should be preceded by a
black filled disc (a black bullet).</p>
-----------------
Approved:
http://test.csswg.org/suites/css2.1/20100701/html4/cursor-applies-to-011.htm
http://test.csswg.org/suites/css2.1/20100701/html4/cursor-applies-to-012.htm
http://test.csswg.org/suites/css2.1/20100701/html4/cursor-applies-to-013.htm
http://test.csswg.org/suites/css2.1/20100701/html4/cursor-applies-to-014.htm
http://test.csswg.org/suites/css2.1/20100701/html4/cursor-applies-to-015.htm
http://test.csswg.org/suites/css2.1/20100701/html4/cursor-fallback-001.htm
------------
Approved:
http://test.csswg.org/suites/css2.1/20100701/html4/cursor-url-001.htm
http://test.csswg.org/suites/css2.1/20100701/html4/system-colors-001.htm
-----------------
Approved:
http://test.csswg.org/suites/css2.1/20100701/html4/outline-001.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-002.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-003.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-004.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-005.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-006.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-007.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-008.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-009.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-010.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-011.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-012.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-013.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-014.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-015.htm
-----------------
http://test.csswg.org/suites/css2.1/20100701/html4/outline-016.htm
<meta name="assert" content="Outline with value inherit uses its
parent's outline values (1 value).">
<style type="text/css">
#div1
{
outline: 15px red solid;
outline: inherit;
}
#wrapper
{
outline: green 15px dotted;
height: 50px;
padding: 50px 50px 50px 50px;
border: solid 2px blue;
}
</style>
<div id="wrapper">
<div id="div1">Filler text</div>
</div>
but #div1 uses 2 of #wrapper's outline values, not 1.
2 of #div1's outline sub-properties are being redefined, not 1.
height: 50px is not needed in the rule for the test.
Personally, I would have given the name #parent to your #wrapper so that
the assert is easier to figure out for beginners.
"listing properties in alphabetical order makes this [review process]
easy."
Suggested replacement:
#wrapper
{
border: blue solid 2px;
outline: green dotted 15px;
padding: 50px 50px 50px 50px;
}
#div1
{
outline: red dotted 15px;
outline: inherit;
}
-----------------
http://test.csswg.org/suites/css2.1/20100701/html4/outline-017.htm
Proposed replacement:
#wrapper
{
border: blue solid 2px;
outline: green dotted 15px;
padding: 50px 50px 50px 50px;
}
-----------------
http://test.csswg.org/suites/css2.1/20100701/html4/outline-018.htm
Proposed replacement:
<meta name="assert" content="Outline with value inherit uses its
parent's outline values (3 values).">
<style type="text/css">
#div1
{
outline: red solid 8px;
outline: inherit;
}
#wrapper
{
border: blue solid 2px;
outline: green dotted 15px;
padding: 50px 50px 50px 50px;
}
-----------------
Approved:
http://test.csswg.org/suites/css2.1/20100701/html4/outline-applies-to-001.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-applies-to-002.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-applies-to-003.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-applies-to-004.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-applies-to-005.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-applies-to-006.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-applies-to-007.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-applies-to-008.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-applies-to-009.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-applies-to-010.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-applies-to-011.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-applies-to-012.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-applies-to-013.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-applies-to-014.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-applies-to-015.htm
-----------------
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-001.htm
IMO, a better test would have been something like:
<meta name="flags" content="invalid">
<meta name="assert" content="Outline color #F4321 (invalid)
falls back to a default color.">
<style type="text/css">
#div1
{
outline-color: #F4321;
because #00000 falls back to invert (or black) which is #000000 anyway,
to begin with.
-----------------
Approved:
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-002.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-003.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-004.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-005.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-006.htm
-----------------
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-007.htm
Proposed adjustment:
#div1
{
outline-color: #7654321;
-----------------
Approved:
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-008.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-009.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-010.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-011.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-012.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-013.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-014.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-015.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-016.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-017.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-018.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-019.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-020.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-021.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-022.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-023.htm
-----------------
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-024.htm
<meta name="assert" content="Outline color #00 (invalid) falls
back to a
default color.">
<style type="text/css">
#div1
{
outline-color: #00;
Proposed replacement:
<style type="text/css">
#div1
{
outline-color: #78;
so that if a browser renders the invalid value - whatever it may be -, it
will/should be a constrasting color from black.
-----------------
Approved:
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-024.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-025.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-026.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-027.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-028.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-029.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-030.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-031.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-032.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-033.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-034.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-035.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-036.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-037.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-038.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-039.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-040.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-041.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-042.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-043.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-044.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-045.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-046.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-047.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-048.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-049.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-050.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-051.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-052.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-053.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-054.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-055.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-056.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-057.htm
-----------------
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-058.htm
The invalid flag should be removed. Out of range value(s) for rgb
function is not invalid, is not ignored: they are clipped or restrained
within the range of values.
The section 4.3.6 gives:
"
em { color: rgb(255,-10,0) } /* clipped to rgb(255,0,0) */
"
http://www.w3.org/TR/CSS21/syndata.html#color-units
The out-of-range value is not rejected: it gets clipped, or restrained
to a ceiling value.
This outline-color-058.htm test is not accurately designed because if the
out-of-range value(s) for rgb() is not processed and parsed correctly for
outline-color, then it should not be expected to done any better for
border-color. So, a tester using an user agent with a weak/incorrect
rgb
handling of values may be comparing 2 exactly identical but wrong colors
(coming from an non-compliant process) and he won't notice anything
wrong.
Proposed adjustments:
<link rel="help"
href="http://www.w3.org/TR/CSS21/ui.html#dynamic-outlines">
<link rel="help" title="4.3.6 Colors"
href="http://www.w3.org/TR/CSS21/syndata.html#color-units">
<meta name="flags" content="">
<meta name="assert" content="Outline color rgb(-12, -34, -56)
renders the correct outline color on the element. For rgb
functions, values outside the support 0..255 range should be
clipped to stay within such range.">
<style type="text/css">
#div1
{
outline-color: rgb(-12, -34, -56);
outline-style: solid;
outline-width: 50px;
margin: 100px 0 0 100px;
width: 0;
}
#reference
{
background-color: rgb(0, 0, 0);
height: 100px;
margin: 200px 0 0 50px;
width: 100px;
}
</style>
-----------------
Approved:
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-059.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-060.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-061.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-062.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-063.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-064.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-065.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-066.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-067.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-068.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-069.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-070.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-071.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-072.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-073.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-074.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-075.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-076.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-077.htm
-----------------
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-078.htm
rgb(101%, 0%, 0%) is not an invalid value in the sense that it should
lead to the rejection of the declaration. So, the invalid flag should be
removed.
The section 4.3.6 gives:
"
em { color: rgb(110%, 0%, 0%) } /* clipped to rgb(100%,0%,0%) */
"
http://www.w3.org/TR/CSS21/syndata.html#color-units
This outline-color-078.htm test is not accurately designed because if the
out-of-range value(s) for rgb() is not processed and parsed correctly for
outline-color, then it should not expected to be done any better for
border-color. So, a tester using an user agent with a weak/incorrect rgb
handling of values may be comparing 2 exactly identical but wrong colors
(coming from an non-compliant process) and he won't notice anything
wrong.
Proposed adjustment:
<link rel="help"
href="http://www.w3.org/TR/CSS21/ui.html#dynamic-outlines">
<link rel="help" title="4.3.6 Colors"
href="http://www.w3.org/TR/CSS21/syndata.html#color-units">
<meta name="flags" content="">
<meta name="assert" content="Outline color rgb(123%, 0%, 0%)
renders the correct outline color on the element. For rgb
functions, values outside the support range should be clipped to
stay within such range.">
<style type="text/css">
#div1
{
outline-color: rgb(123%, 0%, 0%);
outline-style: solid;
outline-width: 50px;
margin: 100px 0 0 100px;
width: 0;
}
#reference
{
background-color: rgb(100%, 0%, 0%);
height: 100px;
margin: 200px 0 0 50px;
width: 100px;
}
</style>
-----------------
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-079.htm
Proposed adjustments:
<link rel="help"
href="http://www.w3.org/TR/CSS21/ui.html#dynamic-outlines">
<link rel="help" title="4.3.6 Colors"
href="http://www.w3.org/TR/CSS21/syndata.html#color-units">
<meta name="flags" content="">
<meta name="assert" content="Outline color rgb(-78, 0, 0)
renders the correct outline color on the element. For rgb
functions, values outside the support range should be clipped to
stay within such range.">
<style type="text/css">
#div1
{
outline-color: rgb(-78, 0, 0);
outline-style: solid;
outline-width: 50px;
margin: 100px 0 0 100px;
width: 0;
}
#reference
{
background-color: rgb(0, 0, 0);
height: 100px;
margin: 200px 0 0 50px;
width: 100px;
}
</style>
-----------------
Approved:
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-080.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-081.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-082.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-083.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-084.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-085.htm
-----------------
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-088.htm
<meta name="flags" content="invalid">
<meta name="assert" content="Outline color rgb(256, 0, 0)
renders the correct outline color on the element.">
Out-of-range value for rgb() function is not an invalid value: the value
gets clipped, restrained within the support range (0..255) and then the
whole declaration is parsable etc.
Proposed adjustment:
<link rel="help"
href="http://www.w3.org/TR/CSS21/ui.html#dynamic-outlines">
<link rel="help" title="4.3.6 Colors"
href="http://www.w3.org/TR/CSS21/syndata.html#color-units">
<meta name="flags" content="">
<meta name="assert" content="Outline color rgb(256, 0, 0)
renders the correct outline color on the element. For rgb
functions, values outside the support range should be clipped to
stay within such range.">
-----------------
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-089.htm
<meta name="flags" content="invalid">
<meta name="assert" content="Outline color rgb(0%, -1%, 0%)
renders the correct outline color on the element.">
Out-of-range value for rgb() function is not an invalid value: the value
gets clipped, restrained within the support range (0..100%) and then the
whole declaration is parsable etc.
Proposed adjustment:
<link rel="help"
href="http://www.w3.org/TR/CSS21/ui.html#dynamic-outlines">
<meta name="flags" content="">
<meta name="assert" content="Outline color rgb(0%, -89%, 0%)
renders the correct outline color on the element. For rgb
functions, values outside the support range should be clipped to
stay within such range.">
<style type="text/css">
#div1
{
outline-color: rgb(0%, -89%, 0%);
outline-style: solid;
outline-width: 50px;
margin: 100px 0 0 100px;
width: 0;
}
#reference
{
background-color: rgb(0%, 0%, 0%);
height: 100px;
margin: 200px 0 0 50px;
width: 100px;
}
</style>
-----------------
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-098.htm
<meta name="flags" content="invalid">
Proposed adjustment:
<link rel="help"
href="http://www.w3.org/TR/CSS21/ui.html#dynamic-outlines">
<meta name="flags" content="">
<meta name="assert" content="Outline color rgb(0%, 123%, 0%)
renders the correct outline color on the element. For rgb
functions, values outside the support range should be clipped to
stay within such range.">
<style type="text/css">
#div1
{
outline-color: rgb(0%, 123%, 0%);
outline-style: solid;
outline-width: 50px;
margin: 100px 0 0 100px;
width: 0;
}
#reference
{
background-color: rgb(0%, 100%, 0%);
height: 100px;
margin: 200px 0 0 50px;
width: 100px;
}
-----------------
test.csswg.org/suites/css2.1/20100701/html4/outline-color-099.htm
Proposed changes:
<link rel="help"
href="http://www.w3.org/TR/CSS21/ui.html#dynamic-outlines">
<meta name="flags" content="">
<meta name="assert" content="Outline color rgb(0, -78, 0)
renders the correct outline color on the element. For rgb
functions, values outside the support range should be clipped to
stay within such range.">
<style type="text/css">
#div1
{
outline-color: rgb(0, -78, 0);
outline-style: solid;
outline-width: 50px;
margin: 100px 0 0 100px;
width: 0;
}
#reference
{
background-color: rgb(0, 0, 0);
height: 100px;
margin: 200px 0 0 50px;
width: 100px;
}
</style>
-----------------
NOT reviewed:
test.csswg.org/suites/css2.1/20100701/html4/outline-color-100.htm
to
test.csswg.org/suites/css2.1/20100701/html4/outline-color-145.htm
have not been reviewed
-----------------
Approved:
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-174.htm
-----------------
Approved:
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-175.htm
-----------------
NOT reviewed:
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-applies-to-001.htm
to
http://test.csswg.org/suites/css2.1/20100701/html4/outline-color-applies-to-015.htm
have not been reviewed
-----------------
Approved:
http://test.csswg.org/suites/css2.1/20100701/html4/outline-individual-001.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-individual-002.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-individual-003.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-individual-004.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-layout-001.htm
------------
http://test.csswg.org/suites/css2.1/20100701/html4/outline-layout-002.htm
Test assertion is not logical, coherent. White outline box of first
inline box overlap "FAIL" of following inline box.
<meta name="assert" content="Outlines do not affect text layout."> does
not describe what is happening in the test. The white outline box
overlaps over the text.
"FAIL" is narrower than 50px in all tested browsers though: so that part
of the test is OK.
------------
Approved:
http://test.csswg.org/suites/css2.1/20100701/html4/outline-layout-003.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-layout-004.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-layout-005.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-no-relayout-001.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-overlap-001.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-style-001.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-style-002.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-style-003.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-style-004.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-style-005.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-style-006.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-style-007.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-style-008.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-style-009.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-style-010.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-style-applies-to-001.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-style-applies-to-002.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-style-applies-to-003.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-style-applies-to-004.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-style-applies-to-005.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-style-applies-to-006.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-style-applies-to-007.htm
-----------------
http://test.csswg.org/suites/css2.1/20100701/html4/outline-style-applies-to-008.htm
and
http://test.csswg.org/suites/css2.1/20100701/html4/outline-width-applies-to-008.htm
Proposed adjustements:
To remove height: 1in; and width: 1in; from the code below since these
do not apply to inline element
<style type="text/css">
div
{
display: inline;
height: 1in;
outline-color: blue;
outline-style: dotted;
outline-width: 10px;
width: 1in;
}
</style>
-----------------
Approved:
http://test.csswg.org/suites/css2.1/20100701/html4/outline-style-applies-to-009.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-style-applies-to-010.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-style-applies-to-011.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-style-applies-to-012.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-style-applies-to-013.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-style-applies-to-014.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-style-applies-to-015.htm
-----------------
Approved:
http://test.csswg.org/suites/css2.1/20100701/html4/outline-style-hidden-001.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-width-001.htm
-----------------
http://test.csswg.org/suites/css2.1/20100701/html4/outline-width-002.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-width-004.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-width-005.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-width-013.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-width-015.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-width-016.htm
I'm not sure I understand the design logic of those tests. [Addendum:
it's probably only the wording, the way it is written.]
<meta name="assert" content="The 'outline-width' property
supports a minimum length value in [pixels|points] that sets the
width of the outline.">
<style type="text/css">
div
{
outline: solid red;
outline-width: 0px;
}
>From what I can understand here, outline requires a positive, non-zero
width value, otherwise it does not display. Unless the minimum referred
to was meant to indicate 0.
-----------------
Approved:
http://test.csswg.org/suites/css2.1/20100701/html4/outline-width-003.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-width-006.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-width-007.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-width-0012.htm
-----------------
http://test.csswg.org/suites/css2.1/20100701/html4/outline-width-014.htm
Proposed correction:
<title>CSS Test: Outline-width with a minimum plus one value in
points</title>
<link rel="author" title="Microsoft"
href="http://www.microsoft.com/">
<link rel="help"
href="http://www.w3.org/TR/CSS21/ui.html#propdef-outline-width">
<link rel="help"
href="http://www.w3.org/TR/CSS21/ui.html#dynamic-outlines">
<meta name="flags" content="">
<meta name="assert" content="The 'outline-width' property
supports a minimum plus one length value in points that sets the
width of the outline.">
<style type="text/css">
#div1
{
margin: 1pt 0 0 1pt;
outline: solid green;
outline-width: 1pt;
width: 300px;
}
#div2
{
border: solid green 1pt;
margin-top: 10px;
width: 300px;
}
</style>
-----------------
Not reviewed
http://test.csswg.org/suites/css2.1/20100701/html4/outline-width-017.htm to
http://test.csswg.org/suites/css2.1/20100701/html4/outline-width-094.htm
Those tests have NOT been reviewed.
-----------------
Approved:
http://test.csswg.org/suites/css2.1/20100701/html4/outline-width-095.htm
-----------------
Approved:
http://test.csswg.org/suites/css2.1/20100701/html4/outline-width-applies-to-001.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-width-applies-to-002.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-width-applies-to-003.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-width-applies-to-004.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-width-applies-to-005.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-width-applies-to-006.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-width-applies-to-007.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-width-applies-to-009.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-width-applies-to-010.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-width-applies-to-011.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-width-applies-to-012.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-width-applies-to-013.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-width-applies-to-014.htm
http://test.csswg.org/suites/css2.1/20100701/html4/outline-width-applies-to-015.htm
-----------------
http://test.csswg.org/suites/css2.1/20100701/html4/outline-pseudo-selector-001.htm
"when the text has focus.": this may not be very helpful, meaningful,
suggestive for "John Doe"
Proposed adjustment:
{Test passes if there is a box around the "Filler Text" below when the
text has focus: the text can be focused by pressing the Tab key.}
Adding an accesskey may be even more useful here.
-----------------
Approved:
http://test.csswg.org/suites/css2.1/20100701/html4/outline-pseudo-selector-002.htm
-----------------
http://test.csswg.org/suites/css2.1/20100701/html4/outline-pseudo-selector-003.htm
Proposed adjustment:
{Test passes if there is a box around the "Filler Text" below when the
text is activated by pressing the mouse button over "Filler Text".}
regards, Gérard Talbot
--
Contributions to the CSS 2.1 test suite:
http://www.gtalbot.org/BrowserBugsSection/css21testsuite/
CSS 2.1 test suite (beta 1; July 1st 2010):
http://test.csswg.org/suites/css2.1/20100701/html4/toc.html
CSS 2.1 test suite contributors:
http://test.csswg.org/source/contributors/
Received on Sunday, 11 July 2010 20:06:35 UTC