W3C home > Mailing lists > Public > www-style@w3.org > April 2016

Re: [css-grid] A few comments

From: Tab Atkins Jr. <jackalmage@gmail.com>
Date: Thu, 21 Apr 2016 14:52:55 -0700
Message-ID: <CAAWBYDCQ_9TFip6vuMgcNQuEuXU3KeXUqFGf02qVr2VpBz733w@mail.gmail.com>
To: Christian Biesinger <cbiesinger@google.com>
Cc: www-style list <www-style@w3.org>
On Thu, Apr 21, 2016 at 7:51 AM, Christian Biesinger
<cbiesinger@google.com> wrote:
> Hi there!
>
> I've done a read through the entire grid spec now, and would like to
> offer some feedback:
>
> 1) There's a few places where named grid areas are used, and it comes
> in three different flavors -- it can be part of a string
> (grid-template-areas), it can be quoted using square brackets
> (grid-template-{columns,rows}) or can be unquoted (grid-area, grid-row
> and others).
>
> I was wondering if it would be easier for authors if they shared a
> more common format? E.g. always require quoting in [brackets],
> including the grid-template-areas ("[foo] [foo]")?

The [foo] syntax is for declaring named lines, not areas - you'll
notice that in the big ascii-art 'grid' clause, you can do both.

> 2) 10.1.3 in the last example
> (https://drafts.csswg.org/css-grid/#common-uses-named-lines):
> As this example comes before the normative definition of how the spans
> are resolved, maybe it would be helpful if the comment elaborated a
> little bit further on how the "span text 2" line is selected. E.g.:
> "Look forward from the start and take the second line named text"

Sure, fixed.

> 3) 12.5 (https://drafts.csswg.org/css-grid/#grid-align): Why are these
> properties (justify-content, align-content) fully defined here,
> instead of referring to css-align like the previous two sections do,
> for justify-{self,items} and align-{self, items}?

Oversight, mostly.  It *should* just defer to Align the same as the
previous sections. The little bits of normative clarification here
need to be moved to Align.

~TJ
Received on Thursday, 21 April 2016 21:53:42 UTC

This archive was generated by hypermail 2.4.0 : Friday, 25 March 2022 10:09:02 UTC