Re: [css-syntax] problem with parse component value

On Tue, Mar 4, 2014 at 12:29 PM, Johannes Koch <koch@w3development.de> wrote:
> Hi,
>
> I think there is a problem with parsing a component value (5.3.6) in the CR.
>
> 4. Reconsume the current input token. Consume a component value and let
> value be the return value. If nothing is returned, return a syntax error.
>
> 5. While the current input token is a <whitespace-token>, consume the next
> input token.
>
> 6. If the current input token is an <EOF-token>, return value. Otherwise,
> return a syntax error.
>
> We need to consume the next input token before step 5. Otherwise at step 5,
> the current input token is the last token of the component value consumed by
> 5.4.6. and cannot be either whitespace or EOF.

Ooh, very good catch.  Fixed.  (Rather than consuming the next token
eagerly, I just changed the condition to look at the next input
token.)

I'm also not sure why I wrote the first couple of steps so awkwardly.
I've instead change them as well to look at the next input token,
rather than eagerly consuming, looking at current, then reconsuming.

~TJ

Received on Tuesday, 4 March 2014 20:38:34 UTC