Re: process for second pull request

We are also worried about tracking all the comments so people can find them. Please feel free to advice on that too!

This is one of the advantages of not opening a second pull request – the comments stay with the pull request. There is a transition when the pull request is made in that the comments initially were in the issue, but once the pull request is opened:

1) the issue should be closed, and a link to the pull request added to the issue
2) Comments should be made on the pull request and not on the issue.


---- On Thu, 09 Feb 2017 21:29:10 +0200 Andrew Kirkpatrick<<>> wrote ----
I’m traveling today and it is late at night for Josh, so we may not be able to answer today, so do not assume that the process you describe below is correct if you don’t hear back today, it may be tomorrow before I can respond fully.


Andrew Kirkpatrick
Group Product Manager, Standards and Accessibility

From: "<>" <<>>
Date: Thursday, February 9, 2017 at 10:43
To: "<>" <<>>
Cc: Andrew Kirkpatrick <<>>, Joshue O Connor <<>>, WCAG <<>>
Subject: process for second pull request

For doing a second pull request I suggested to coga the following process (because none of us knew what to do)

Please let us know today if anything here is incorrect.
(changes are in bold)

  *    Develop a pull request on GitHub containing the new wording.

  1.  Fork the WCAG21 repository to your own GitHub account
  2.  Create a branch off of the Master branch (use a logical name for the branch, e.g. "Accessible authentication version 2 ”)
  3.  Open the directory "guidelines" in your new branch
  4.  open index. html , press the edit box
  5.  navigate to the right guideline and  issert the following  with the SC text in the following mark up

<section class="sc">

<h4> </h4>

<p class="conformance-level">AA</p>



  1.  Navigate to the glossary and add any new glossary  items (hopefully in the right place)
  2.  Save and create the pull request for the Master branch.

  3.  When the Pull request is made:

  1.  Provide the link to the first  pull request with some text along the lines of "this is a second pull request in response to the comments from the pull request at ...)
  2.  Provide the link to the original issue in the pull request comments as well.
  3.   Provide the link to the second pull request  from the first pull requet

ll the best

Lisa Seeman

LinkedIn<>, Twitter<>

All the best

Lisa Seeman

LinkedIn<>, Twitter<>

Received on Thursday, 9 February 2017 23:00:38 UTC