W3C home > Mailing lists > Public > public-webrtc@w3.org > December 2014

Re: pc.localDescription sync/async issue

From: Jan-Ivar Bruaroey <jib@mozilla.com>
Date: Fri, 12 Dec 2014 14:56:28 -0500
Message-ID: <548B486C.70404@mozilla.com>
To: "public-webrtc@w3.org" <public-webrtc@w3.org>
Turns out I misread our code a bit, we only cache the "type". I'm less 
concerned about this so I'm happy to leave it alone. I understand a lot 
went into this piece.

.: Jan-Ivar :.

On 12/12/14, 2:24 PM, Jan-Ivar Bruaroey wrote:
> I just found out that - in our implementation - users can read 
> pc.localDescription synchronously right after having called 
> setLocalDescription and get the result they are in the process of 
> setting, even before it has finished (!)
>
> This seems quite wrong - especially if setLocalDescription were to 
> fail - but I'm not confident it's not a spec issue.
>
> Confusingly, the spec in http://w3c.github.io/webrtc-pc/#attributes says:
>
> "The localDescription attribute MUST return the RTCSessionDescription 
> that was most recently passed to setLocalDescription(), plus any local 
> candidates that have been generated by the ICE Agent since then."
>
> Since setLocalDescription() is asynchronous, this is ambiguous. Could 
> this be worded better with regard to what it should return when 
> setLocalDescription has been called but its callbacks haven't been?
>
> Hopefully it's uncontentious that it should return null or any 
> previous description if there is one.
>
> .: Jan-Ivar :.
Received on Friday, 12 December 2014 19:56:56 UTC

This archive was generated by hypermail 2.3.1 : Monday, 23 October 2017 15:19:42 UTC