- From: youennf via GitHub <sysbot+gh@w3.org>
- Date: Mon, 21 Mar 2022 14:35:54 +0000
- To: public-webrtc-logs@w3.org
Looking at the new PR, I think it is missing the forStorage handling, something like: - Add forStorage as parameter to the serialisation steps algorithm. - As first step of the algorithm, throw an exception if forStorage is set to true. I also think it would be preferable to move away from using UUIDs, which is currently a half-defined mechanism anyway. Instead, we could do the following: - A CropTarget has a weak reference to its element as a private slot, say cropTarget.[[Element]] (weak reference since we do not want to keep the element alive if crop targets are still in the air). - When serialisation happens, set serialised.[[cropTargetElement]] to cropTarget.[[Element]]. - When deserialisation happens, create a CropTarget and set its [[Element]] to serialised.[[cropTargetElement]]. -- GitHub Notification of comment by youennf Please view or discuss this issue at https://github.com/w3c/mediacapture-region/pull/24#issuecomment-1073978406 using your GitHub account -- Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Monday, 21 March 2022 14:35:56 UTC