- From: Elad Alon via GitHub <sysbot+gh@w3.org>
- Date: Mon, 21 Mar 2022 15:47:52 +0000
- To: public-webrtc-logs@w3.org
> Looking at the new PR, I think it is missing the forStorage handling, something like: > > * Add forStorage as parameter to the serialisation steps algorithm. > * As first step of the algorithm, throw an exception if forStorage is set to true. On the PR itself, I have quoted this part: > The introduction of these steps should omit mention of the forStorage argument if it is not relevant to the algorithm. It's taken from [here](https://whatpr.org/html/6523/structured-data.html#serializable-objects). I read it as "ignore this if it's not relevant." Seems irrelevant enough to me. Or why do you think it's important to specify throwing? > I also think it would be preferable to move away from using UUIDs, which is currently a half-defined mechanism anyway. The PR does not mention UUIDs. (And that's intentional.) > Instead, we could do the following: > > * A CropTarget has a weak reference to its element Please recall that the element is in another document. Potentially a cross-origin document. -- GitHub Notification of comment by eladalon1983 Please view or discuss this issue at https://github.com/w3c/mediacapture-region/pull/24#issuecomment-1074065001 using your GitHub account -- Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Monday, 21 March 2022 15:47:53 UTC