Re: [w3c/payment-request] Changes resulting from 28 February PING privacy review (#843)

@rsolomakhin 

> Where in the canMakePayment algorithm are supportedNetworks mentioned?

Ah, I see my error here.  [3.5](https://w3c.github.io/payment-request/#dom-paymentrequest-canmakepayment) says `supportedNetworks` doesn't matter.  But in the definition of the `show()` algorithm, in step 15.6.1 it says `canMakePayment` is the result of [checking the result of each handler](https://w3c.github.io/payment-request/#dfn-steps-to-check-if-a-payment-can-be-made) (which would include [`supportedNetworks`](https://www.w3.org/TR/payment-method-basic-card/#steps-to-check-if-a-payment-can-be-made)).

So, 100% my error, but would be good to rename `canMakePayment` the variable in the [`show()`](https://w3c.github.io/payment-request/#show-method) algorithm, to something else, to avoid confusion with the `canMakePayment` method.  `isHandlerSupported`? Thoughts?

This is even more confusing because the `canMakePayment` note says "[canMakePayment checks if] the user agent supports any of the desired payment methods".  When I click on `payment methods`, i'm taken to a link that says "the party that provides the means (e.g., credit card) that the payer uses to pay". Since "Visa" and "Mastercard" are parties, but "a credit card" is not a party, the "NOTE" text seems to suggest the `canMakePayment` text is describing "does the user agent have a visa card set up" and not  "does the user agent have a credit card" set up. 

On looking closer, i see that "payment method" is in bold, followed by provider (not in bold), so I'm left even more confused whether this is a definition of a payment method, a provider of a payment method (and if so, why was I was linked here? and I still don't know what a payment method is).

I suggest cleaning all this up, and explicitly defining more terms.  I see that I've misunderstood what `canMakePayment` (method, not the variable) is intended to do.  But I hope I've shown why the document isn't helping ;)


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/payment-request/pull/843#issuecomment-470262761