- From: ianbjacobs <notifications@github.com>
- Date: Wed, 07 Jun 2017 13:52:31 -0700
- To: w3c/payment-handler <payment-handler@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 7 June 2017 20:53:04 UTC
Thank you, @rsolomakhin, for starting this! I have a couple of comments that suggest some updates to the pull request: - We will need to update the introductory text (Overview of Handling Payment Requests) to indicate at a high level how capability matching happens (through the event). We should also add a mention of AbortPaymentEvent() to the overview. - I think that the addition of CanMakePaymentEvent means that PaymentInstrument.capabilities is no longer required and can be deleted. - Let's augment examples with these two events. In particular, for CanMakePaymentEvent, let's include an example of basic card capability matching. - Similarly, the registration example in 5.7 will need to drop mention of the capabilities method. - Regarding AbortPaymentEvent(), I think we need some additional explanatory text that the event does not mean that the payment app must abort the payment in order to conform. As we discussed on the call, this is a signal from the merchant and behavior may change depending on payment method and transaction status. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/payment-handler/pull/170#issuecomment-306921215
Received on Wednesday, 7 June 2017 20:53:04 UTC