Re: [widgets] Some possible i18n test bugs

On Wed, Dec 8, 2010 at 3:26 PM, Scott Wilson
<scott.bradley.wilson@gmail.com> wrote:
> I've identified a few more possible test bugs. If there are no objections
> I'll make the changes I've suggested below and commit them.
>
> 1. i18nrl20.wgt Tests that nested LRO and RTL directions apply correctly to
> the name element. To pass, the displayed value of the name element must
> render as "< PASSED -->".
>
> <widget id="i18nlro20:" xmlns="http://www.w3.org/ns/widgets">
>    <name><span dir="lro">&lt; PAS<span dir="rtl">&lt;--
> SED</span></span></name>
> </widget>
>
> However I'm pretty sure that the result you should get from this is:
>
> < PASDES-->
>
> Which is what Wookie generates. I think the test should be:
>
> <widget id="i18nlro20:" xmlns="http://www.w3.org/ns/widgets">
>    <name><span dir="lro">&lt; PAS<span dir="rtl">&lt;--
> DES</span></span></name>
> </widget>
>
> 2. 18nrlo02.wgt Tests that RLO direction applies to the name element's short
> attribute. To pass, the displayed value must render as "PASSED".
>
> <widget id="i18nrlo02:" xmlns="http://www.w3.org/ns/widgets">
>    <name dir="ltr"> a <span dir="rlo">TSET</span> (3)</name>
> </widget>
> This clearly isn't correct. I think it should be:
>
> <widget id="i18nrlo02:" xmlns="http://www.w3.org/ns/widgets">
>    <name dir="ltr">P<span dir="rlo">DESSA</span> (3)</name>
> </widget>
>
>
> 3.i18nrtl21.wgt Tests that nested RTL and LRO directions apply correctly to
> the name element. To pass, the displayed value must render as "< PASSED
> -->".
> <widget id="i18nrtl21:" xmlns="http://www.w3.org/ns/widgets">
>    <name><span dir="rtl">PAS<span dir="lro">SED --&gt;</span>
> &gt;</span></name>
>    <description>The name should be "&lt; PASSED --&gt;"</description>
> </widget>
> I get "< SED-->SAP" for this one; I think this should be:
>
> <widget id="i18nrtl21:" xmlns="http://www.w3.org/ns/widgets">
>    <name><span dir="rtl">SAP &gt;<span dir="lro">SED
> --&gt;</span></span></name>
>    <description>The name should be "&lt; PASSED --&gt;"</description>
> </widget>
>
> 4. 18nrtl22.wgt Tests that nested RTL and RLO directions apply correctly to
> the name element. To pass, the displayed value must render as "< PASSED
> -->".
>
> <widget id="i18nrtl22:" xmlns="http://www.w3.org/ns/widgets">
>    <name><span dir="rtl">PAS<span dir="rlo">&lt;-- DES</span>
> &gt;</span></name>
>    <description>The name should be "&lt; PASSED --&gt;"</description>
> </widget>
>
> I get "< SED-->SAP" for this one; I think this should be:
>
> <widget id="i18nrtl22:" xmlns="http://www.w3.org/ns/widgets">
>    <name><span dir="rtl">SAP &gt;<span dir="rlo">&lt;--
> DES</span></span></name>
>    <description>The name should be "&lt; PASSED --&gt;"</description>
> </widget>

I'm ok with those changes. Please also update the hook.js files :)



-- 
Marcos Caceres
Opera Software ASA, http://www.opera.com/
http://datadriven.com.au

Received on Thursday, 9 December 2010 00:19:04 UTC