- From: Domenic Denicola <notifications@github.com>
- Date: Mon, 06 May 2024 19:11:45 -0700
- To: w3c/ServiceWorker <ServiceWorker@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 7 May 2024 02:11:49 UTC
@domenic requested changes on this pull request. > @@ -1453,7 +1453,7 @@ spec: storage; urlPrefix: https://storage.spec.whatwg.org/ 1. Run these substeps <a>in parallel</a>: 1. Let |newContext| be a new [=top-level browsing context=]. 1. [=Queue a task=] to run the following steps on |newContext|'s {{Window}} object's [=environment settings object=]'s [=responsible event loop=] using the [=user interaction task source=]: - 1. *HandleNavigate*: [=Navigate=] |newContext| to |url| with [=exceptionsEnabled=] true, and [=historyHandling=] "<code>replace</code>". + 1. *HandleNavigate*: [=Navigate=] |newContext| to |url| with [=exceptionsEnabled=] true, and [=history handling behavior=] "<code>replace</code>". This should actually be something like `<i>[=navigate/historyHandling=]</i>`. We want to link to https://html.spec.whatwg.org/multipage/browsing-the-web.html#navigation-hh instead of https://html.spec.whatwg.org/multipage/browsing-the-web.html#history-handling-behavior . And https://github.com/whatwg/html/pull/10308/files will need some updates for that. -- Reply to this email directly or view it on GitHub: https://github.com/w3c/ServiceWorker/pull/1715#pullrequestreview-2041939652 You are receiving this because you are subscribed to this thread. Message ID: <w3c/ServiceWorker/pull/1715/review/2041939652@github.com>
Received on Tuesday, 7 May 2024 02:11:49 UTC