Re: [w3c/ServiceWorker] Editorial: fixed the bikeshed errors (PR #1715)

@domenic commented on this pull request.



> @@ -1453,7 +1453,7 @@ spec: storage; urlPrefix: https://storage.spec.whatwg.org/
         1. Run these substeps <a>in parallel</a>:
             1. Let |newContext| be a new [=top-level browsing context=].
             1. [=Queue a task=] to run the following steps on |newContext|'s {{Window}} object's [=environment settings object=]'s [=responsible event loop=] using the [=user interaction task source=]:
-                1. *HandleNavigate*: [=Navigate=] |newContext| to |url| with [=exceptionsEnabled=] true, and [=historyHandling=] "<code>replace</code>".
+                1. *HandleNavigate*: [=Navigate=] |newContext| to |url| with [=exceptionsEnabled=] true, and <i>[=navigate/historyHandling=]</i> "<code>replace</code>".

I think you will need to change this to `navigate/exceptionsEnabled` after https://github.com/whatwg/html/pull/10308 lands.

> @@ -3113,7 +3113,7 @@ spec: storage; urlPrefix: https://storage.spec.whatwg.org/
           1. Otherwise, set |callback| to the result of [=convert to an ECMAScript value|converting to an ECMAScript value=] |eventListenerCallback|.
           1. If [$IsCallable$](|callback|) is false, then return false.
 
-              Note: [=Event listener/Callback=] objects that use {{handleEvent}} are assumed to be non-empty. This avoids calling the {{handleEvent}} getters, which could modify the event listeners during this check.
+              Note: [=event listener/Callback=] objects that use <code>handleEvent</code> are assumed to be non-empty. This avoids calling the <code>handleEvent</code> getters, which could modify the event listeners during this check.

I think these could be `{{EventListener/handlEvent(event)}}` and keep the auto-linking

> @@ -2094,7 +2094,7 @@ spec: storage; urlPrefix: https://storage.spec.whatwg.org/
                 1. Invoke [=Batch Cache Operations=] with |operations|. If this [=throws=] an exception, set |errorData| to the exception.
                 1. [=Queue a task=], on |cacheJobPromise|'s [=relevant settings object=]'s [=responsible event loop=] using the [=DOM manipulation task source=], to perform the following substeps:
                     1. If |errorData| is null, resolve |cacheJobPromise| with undefined.
-                    1. Else, reject |cacheJobPromise| with a [=exception/create|new=] [=exception=] with |errorData| and a user agent-defined [=exception/message=], in |realm|.
+                    1. Else, reject |cacheJobPromise| with a [=exception/create|new=] [=exception=] with |errorData| and a user agent-defined [=DOMException/message=], in |realm|.

What you have done here is OK but the default is a user agent-defined message, so you can instead just omit " and a user agent-defined message".

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/ServiceWorker/pull/1715#pullrequestreview-2044876200
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/ServiceWorker/pull/1715/review/2044876200@github.com>