Re: [whatwg/fullscreen] Don't close ancestor popovers when fullscreening (PR #237)

@domenic approved this pull request.

LGTM with nit I will fix while merging

> @@ -67,7 +67,13 @@ is an <a>ordered set</a> of (<a>string</a>, <a>element</a>) <a>tuples</a>. It is
 <p>To <dfn>fullscreen an <var>element</var></dfn>:
 
 <ol>
- <li><p>Run <a>hide all popovers</a> given <var>element</var>'s <a>node document</a>.
+ <li><p>Let <var>hideUntil</var> be the result of running <a>topmost popover ancestor</a> given
+ <var>element</var>, null, and false.
+
+ <li><p>If <var>hideUntil</var> is null, then set <var>hideUntil</var> to <var>element</var>'s
+ <span>node document</span>.</p></li>

```suggestion
 <span>node document</span>.
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fullscreen/pull/237#pullrequestreview-2041947019
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fullscreen/pull/237/review/2041947019@github.com>

Received on Tuesday, 7 May 2024 02:22:07 UTC