- From: Anne van Kesteren <notifications@github.com>
- Date: Thu, 04 May 2023 01:29:39 -0700
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 4 May 2023 08:29:45 UTC
@annevk commented on this pull request. This looks mostly okay, except for some editorial work. Also, we should update the warning (as per https://github.com/whatwg/fetch/issues/1512#issuecomment-1289065530) to indicate you might get bytes back from an opaque response and thus you have to tread carefully when not using CORS. > + <li><p>Let <var>actualResponse</var> be <var>response</var>'s + <a for="filtered response">internal response</a> if <var>response</var> is a + <a>filtered response</a>; Otherwise <var>response</var>. 1. Since this is after main fetch it's always going to be a filtered response or a network error. Hence we should have a step equivalent to step 15 of main fetch. (Might want to update the wording though as this does if/otherwise better, except that otherwise needs to be lowercase.) 2. We should use the same variable name throughout the specification. We use both actualResponse and internalResponse. _internalResponse_ seems clearer to me. -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/fetch/pull/1645#pullrequestreview-1412564605 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/fetch/pull/1645/review/1412564605@github.com>
Received on Thursday, 4 May 2023 08:29:45 UTC