- From: Anne van Kesteren <notifications@github.com>
- Date: Mon, 08 May 2023 00:19:13 -0700
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Monday, 8 May 2023 07:19:19 UTC
@annevk commented on this pull request. > @@ -4792,7 +4792,11 @@ steps: <a for="fetch params">process response</a> given <var>response</var>, with <var>fetchParams</var>'s <a for="fetch params">task destination</a>. - <li><p>If <var>response</var>'s <a for=response>body</a> is null, then run + <li><p>Let <var>internalResponse</var> be <var>response</var>, if <var>response</var> is a + <a>network error</a>; otherwise <var>response</var>'s + <a for="filtered response">internal response</a> otherwise. Drop "otherwise" at the end here. Also not entirely sure we need the comma before "if". I think we usually leave it out if the sentences are relatively short. -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/fetch/pull/1645#pullrequestreview-1416254691 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/fetch/pull/1645/review/1416254691@github.com>
Received on Monday, 8 May 2023 07:19:19 UTC