Re: [whatwg/fetch] Add more timing information about (interim) responses (PR #1483)

@annevk commented on this pull request.



> @@ -5744,6 +5751,14 @@ optional boolean <var>forceNewConnection</var> (default false), run these steps:
          <li><p>If <var>request</var>'s <a for=request>mode</a> is "<code>websocket</code>" and
          <var>status</var> is 101, then <a for=iteration>break</a>.
 
+         <li><p>If <var>timingInfo</var>'s
+         <a for="fetch timing info">first interim network-response start time</a> is 0, then set
+         <var>timingInfo</var>'s
+         <a for="fetch timing info">first interim network-response start time</a> to
+         <var>timingInfo</var>'s <a for="fetch timing info">final network-response start time</a>.
+
+         <li><p>If <var>status</var> is 101, <a for=iteration>break</a>.

Where is this coming from? This seems wrong.

> @@ -5744,6 +5751,14 @@ optional boolean <var>forceNewConnection</var> (default false), run these steps:
          <li><p>If <var>request</var>'s <a for=request>mode</a> is "<code>websocket</code>" and
          <var>status</var> is 101, then <a for=iteration>break</a>.
 
+         <li><p>If <var>timingInfo</var>'s
+         <a for="fetch timing info">first interim network-response start time</a> is 0, then set
+         <var>timingInfo</var>'s
+         <a for="fetch timing info">first interim network-response start time</a> to
+         <var>timingInfo</var>'s <a for="fetch timing info">final network-response start time</a>.

I think this is good, but it doesn't match the description given in https://github.com/w3c/resource-timing/pull/366.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1483#pullrequestreview-1412610050
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fetch/pull/1483/review/1412610050@github.com>