Re: [w3c/IndexedDB] Disambiguate "running" for transactions (PR #409)

@evanstade commented on this pull request.



>  <!-- ============================================================ -->
 
 <div algorithm>
 
-To <dfn>run an upgrade transaction</dfn> with |connection| (a [=/connection=])
+To <dfn>upgrade a database</dfn> with |connection| (a [=/connection=])
 which is used to update the [=/database=], a new |version| to be set

> which is used to update the database

This part seems a little superfluous maybe.

>    The {{IDBOpenDBRequest/upgradeneeded!!event}} event isn't fired, and thus the
   [=/upgrade transaction=] isn't started, until all other
   [=/connections=] to the same [=/database=] are closed. This ensures
   that all previous transactions are [=transaction/finished=]. As long
-  as an [=/upgrade transaction=] is running, attempts to open more
+  as an [=/upgrade transaction=] is [=transaction/live=], attempts to open more
   [=/connections=] to the same [=/database=] are delayed, and any
   attempts to use the same [=/connection=] to start additional
   transactions by calling {{IDBDatabase/transaction()}} will throw an
   exception. Thus [=/upgrade transactions=] not only ensure that no

It seems that it's not actually the upgrade transaction doing the work here, but the connection queue?

It may be true that there can't be concurrent upgrade transactions, but the upgrade transactions aren't themselves ensuring that.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/IndexedDB/pull/409#pullrequestreview-1559669322
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/IndexedDB/pull/409/review/1559669322@github.com>