- From: Austin Sullivan <notifications@github.com>
- Date: Wed, 02 Aug 2023 17:05:06 -0700
- To: w3c/IndexedDB <IndexedDB@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 3 August 2023 00:05:11 UTC
@a-sully approved this pull request. LGTM % optional nits > @@ -1001,7 +1001,7 @@ Transactions are expected to be short lived. This is encouraged by the described below. <aside class=note> - Authors can still cause transactions to run for a long time; + Authors can still cause transactions to stay alive for a long time; ```suggestion Authors can still cause transactions to stay [=transaction/live|alive=] for a long time; ``` Shall we linkify this? > <!-- ============================================================ --> <div algorithm> -To <dfn>run an upgrade transaction</dfn> with |connection| (a [=/connection=]) -which is used to update the [=/database=], a new |version| to be set -for the [=/database=], and a |request|, run these steps: +To <dfn>upgrade a database</dfn> with |connection| (a [=/connection=]), a new |version|, and a |request|, run these steps: Do you think it's worthwhile to preserve the old ID? There probably don't exist many references to https://www.w3.org/TR/IndexedDB/#run-an-upgrade-transaction out on the interwebs, but if there are they'd be broken -- Reply to this email directly or view it on GitHub: https://github.com/w3c/IndexedDB/pull/409#pullrequestreview-1559975928 You are receiving this because you are subscribed to this thread. Message ID: <w3c/IndexedDB/pull/409/review/1559975928@github.com>
Received on Thursday, 3 August 2023 00:05:11 UTC