Re: [w3c/manifest] Add support for defining a theme color for both light & dark modes (prefers color scheme) (#975)

(late to the party)

I do like this unified design to both the translations and theme colour work. It's great to have people thinking across use cases like this. 👍 

I do have some thoughts on the specifics:

1. We do seem to be back to using CSS media queries (`"(prefers-color-scheme: dark)"`). I thought we discussed this above and came to a conclusion that that was overkill. I am quite concerned about this. I don't think it's implementable, and if we can implement it, it drastically complicates the manifest parser (to include a large chunk of the CSS parser). I might be proven wrong here, but I would want to see a detailed sketch of how a user agent like Chromium might go about implementing the MQ parser (as well as how we would process it in all the OSes that we support), before we go down this route.
2. Contrary to what I said above, I think `"overrides"` is the best name that you've suggested. You mentioned `"redefine"` and `"replace"` because they're "active"; I think it's not good to name things as active names inside a declarative format. We should think of this in the passive sense as "these are the overrides", not active "replace the above with these".
3. I don't like reusing the key `"context"` for both user preferences and translations. In the former, it's a media query; in the latter it's a language name. The name of the key should reflect the thing you want to put in it, so for example in translations, it should be called `"language"`.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/issues/975#issuecomment-953494121