- From: Matt Giuca <notifications@github.com>
- Date: Thu, 28 Oct 2021 18:21:46 -0700
- To: w3c/manifest <manifest@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/manifest/issues/975/954336241@github.com>
@aarongustafson 1. I think it's important to figure out whether we're doing the light/dark thing _just_ for an active browser window (e.g. the title bar colour), or if we're intending to apply it wherever a manifest is used (e.g. in OS shelf icons). If it's the former, then I think it's tractable (but still architecturally difficult) to use a CSS MQ since that code resides within the browser. If the latter, it means we need to find a way to translate the MQ condition out into every OS. While Chrome OS is probably easier since we control it, it isn't limitless -- we don't really want to put a CSS engine into the OS app service just to calculate theme colours. 2. Note that "override" is already a word (e.g. `display_override`); I don't think the spelling is a problem (this isn't one of those words that can be spelled two ways, "overide" is simply a misspelling, like "referer" lol). 3. I think we need to workshop the layout of the combined translations / color scheme further, but if anything, if we want to generalize it, I would look at generalizing the top-level object. You have `translations / context` and `user-preferences / context`, and I was suggesting to rename "context" to perhaps `language` and `color-scheme` so it's clear what "type" it has. If you want to generalize it, you might consider generalizing the top-level one to just `alternatives` (for example), with `language` and `color-scheme` as selectors inside it. This would potentially open up a can of worms allowing for `alternatives` with both a `language` and `color-scheme` selector -- I'm not sure it's worth allowing for combinatorial conditions like this, so my preference would be to keep the designs consistent, but separate: `translations / language` and `user-preferences / color-scheme`. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/w3c/manifest/issues/975#issuecomment-954336241
Received on Friday, 29 October 2021 01:22:00 UTC