Re: [w3c/manifest] Add support for defining a theme color for both light & dark modes (prefers color scheme) (#975)

@mgiuca Thanks!

1. Agreed. Not my area of expertise (nor a strongly held opinion from my side). I can do some digging as to how adaptive icons show up in Windows and Mac. I imagine Chrome OS would be substantially easier, but I could be wrong.
2. I’m cool with "overrides" (acknowledging the probable spelling issue).
3. I don’t disagree, but I am curious how you might define a generic though. Would it be an object with a single "overrides" member and a not about it requiring the addition of a "context"? Or could we have the "context" member in the generic and then allow it to be renamed for the individual implementations (to "media" and "language"/"lang")? I don’t know enough about Infra to know which approach is recommended here.

Once we come to a resolution on 3, I’m happy to write up an explainer for the generic (and help adapt the translations explainer) to align while we sort out the media portion (which also influences `ImageResource`).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/manifest/issues/975#issuecomment-954287640

Received on Thursday, 28 October 2021 23:05:35 UTC