Re: [whatwg/xhr] Resource Timing integration (#319)

@annevk commented on this pull request.

Apologies for not updating this sooner. While reviewing this I ended up filing https://github.com/whatwg/fetch/issues/1201, but forgot to write down the bits that didn't add up for me here.

> @@ -1018,6 +1024,8 @@ return <a>this</a>'s <a>cross-origin credentials</a>.
 <ol>
  <li><p>Set <var>xhr</var>'s <a>state</a> to <i>done</i>.
 
+ <li><p><a for=/>Report timing</a> for <var>xhr</var>.

We report timings here, but two steps down we set response to a network error. Whereas above we don't report timing at all if response is a network error.

Now per https://github.com/whatwg/fetch/pull/1202 maybe some network errors should get report timing, but I don't think the current setup makes that happen correctly, right?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/xhr/pull/319#pullrequestreview-634597061