Re: [whatwg/xhr] Resource Timing integration (#319)

DONTNOT REALY MY ASK?

در تاریخ سه‌شنبه ۱۳ آوریل ۲۰۲۱،‏ ۶:۰۶ ب.ظ Anne van Kesteren <
***@***.***> نوشت:

> ***@***.**** commented on this pull request.
>
> Apologies for not updating this sooner. While reviewing this I ended up
> filing whatwg/fetch#1201 <https://github.com/whatwg/fetch/issues/1201>,
> but forgot to write down the bits that didn't add up for me here.
> ------------------------------
>
> In xhr.bs <https://github.com/whatwg/xhr/pull/319#discussion_r612452423>:
>
> > @@ -1018,6 +1024,8 @@ return <a>this</a>'s <a>cross-origin credentials</a>.
>  <ol>
>   <li><p>Set <var>xhr</var>'s <a>state</a> to <i>done</i>.
>
> + <li><p><a for=/>Report timing</a> for <var>xhr</var>.
>
> We report timings here, but two steps down we set response to a network
> error. Whereas above we don't report timing at all if response is a network
> error.
>
> Now per whatwg/fetch#1202 <https://github.com/whatwg/fetch/pull/1202>
> maybe some network errors should get report timing, but I don't think the
> current setup makes that happen correctly, right?
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/whatwg/xhr/pull/319#pullrequestreview-634597061>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AELDFIMOI2DVBL7XANNQKL3TIRCF3ANCNFSM4ZK5O6XA>
> .
>


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/xhr/pull/319#issuecomment-818826900

Received on Tuesday, 13 April 2021 15:28:24 UTC